Workaround for NotificationManager race condition

Workaround for NotificationManager race condition

It looks like we occasionally handle the notification click intent
while the notification is still temporarily there.  This check adds the
notification id of the dying notification to the intent, so we can
ignore it when scanning the existing notifications to see if any still
require us to have our summary notification active.

BUG=709560
Review-Url: https://codereview.chromium.org/2805843002
Cr-Commit-Position: refs/heads/master@{#463120}
Committed: https://chromium.googlesource.com/chromium/src/+/ce4c38c5b3535bcb4a08cf2771db378aa8f278f9

[David Trainor- moved to gerrit, 2017-04-07 06:38:37]

dtrainor@chromium.org changed reviewers:
+ qinmin@chromium.org

[David Trainor- moved to gerrit, 2017-04-07 06:38:38]

I'm still seeing this fail rarely :(.  It looks like this intent is getting
handled when the notification isn't gone yet infrequently... I can see that this
is the scenario when it happens.  This change catches this case.

ptal

[David Trainor- moved to gerrit, 2017-04-07 18:53:00]

Description was changed from

==========
Workaround for NotificationManager race condition

It looks like we occasionally handle the notification click intent
while the notification is still temporarily there.  This check adds the
notification id of the dying notification to the intent, so we can
ignore it when scanning the existing notifications to see if any still
require us to have our summary notification active.

BUG=699323
==========

to

==========
Workaround for NotificationManager race condition

It looks like we occasionally handle the notification click intent
while the notification is still temporarily there.  This check adds the
notification id of the dying notification to the intent, so we can
ignore it when scanning the existing notifications to see if any still
require us to have our summary notification active.

BUG=709560
==========

[qinmin, 2017-04-07 19:03:14]

lgtm % comments

https://codereview.chromium.org/2805843002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2805843002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:84:
static final String EXTRA_NOTIFICATION_ID =
can we reuse the EXTRA_NOTIFICATION_ID else where?

[David Trainor- moved to gerrit, 2017-04-07 20:53:55]

https://codereview.chromium.org/2805843002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
(right):

https://codereview.chromium.org/2805843002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java:84:
static final String EXTRA_NOTIFICATION_ID =
On 2017/04/07 19:03:13, qinmin wrote:
> can we reuse the EXTRA_NOTIFICATION_ID else where?

Done.

[David Trainor- moved to gerrit, 2017-04-07 20:54:00]

The CQ bit was checked by dtrainor@chromium.org

[David Trainor- moved to gerrit, 2017-04-07 20:54:00]

The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org
Link to the patchset: https://codereview.chromium.org/2805843002/#ps40001
(title: "Addressed comments")

[commit-bot: I haz the power, 2017-04-07 20:54:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 21:04:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 21:04:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[David Trainor- moved to gerrit, 2017-04-07 22:09:52]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:10:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 22:20:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:20:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[David Trainor- moved to gerrit, 2017-04-08 03:04:28]

The CQ bit was checked by dtrainor@chromium.org

[commit-bot: I haz the power, 2017-04-08 03:04:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 03:12:00]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491620668347940,
"parent_rev": "55ebb2ef5dee714d827f8e06a03ddc23786c44be", "commit_rev":
"ce4c38c5b3535bcb4a08cf2771db378aa8f278f9"}

[commit-bot: I haz the power, 2017-04-08 03:12:47]

Description was changed from

==========
Workaround for NotificationManager race condition

It looks like we occasionally handle the notification click intent
while the notification is still temporarily there.  This check adds the
notification id of the dying notification to the intent, so we can
ignore it when scanning the existing notifications to see if any still
require us to have our summary notification active.

BUG=709560
==========

to

==========
Workaround for NotificationManager race condition

It looks like we occasionally handle the notification click intent
while the notification is still temporarily there.  This check adds the
notification id of the dying notification to the intent, so we can
ignore it when scanning the existing notifications to see if any still
require us to have our summary notification active.

BUG=709560

Review-Url: https://codereview.chromium.org/2805843002
Cr-Commit-Position: refs/heads/master@{#463120}
Committed:
https://chromium.googlesource.com/chromium/src/+/ce4c38c5b3535bcb4a08cf2771db...
==========

[commit-bot: I haz the power, 2017-04-08 03:12:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ce4c38c5b3535bcb4a08cf2771db...