Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2813563006: Reland: PPC/s390 [ignition] Add call bytecodes for undefined receiver (Closed)

Created:
3 years, 8 months ago by JaideepBajwa
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Reland: PPC/s390 [ignition] Add call bytecodes for undefined receiver Port 57afd0bb077c777529eab577a054fbc117d26fb3 Original Commit Message: Adds a collection of call bytecodes which have an implicit undefined receiver argument, for cases such as global calls where we know that the receiver has to be undefined. This way we can skip an LdaUndefined, decrease bytecode register pressure, and set a more accurate ConvertReceiverMode on the interpreter and TurboFan call. As a side effect, the "normal" Call bytecode now becomes a rare case (only with calls and super property calls), so we get rid of its 0-2 argument special cases and modify CallProperty[N] to use the NotNullOrUndefined ConvertReceiverMode. Reland of https://chromium-review.googlesource.com/c/463287 after fixing tests in https://codereview.chromium.org/2813873002. R=leszeks@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2813563006 Cr-Commit-Position: refs/heads/master@{#44589} Committed: https://chromium.googlesource.com/v8/v8/+/cb4ceee29814167de93bde9b598525b245efdcf8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -22 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 5 chunks +20 lines, -11 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 5 chunks +19 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
john.yan
lgtm
3 years, 8 months ago (2017-04-11 17:29:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813563006/1
3 years, 8 months ago (2017-04-11 17:31:04 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 17:53:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/cb4ceee29814167de93bde9b598525b245e...

Powered by Google App Engine
This is Rietveld 408576698