Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2813563005: Remove fast path checks that look into the Groups in ComputedStyle (Closed)

Created:
3 years, 8 months ago by nainar
Modified:
3 years, 8 months ago
Reviewers:
shend
CC:
shend, blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fast path checks that look into the Groups in ComputedStyle BUG=

Patch Set 1 #

Patch Set 2 : Remove fast path checks that look into the Groups #

Total comments: 1

Patch Set 3 : Reintroduce comparison of objects #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -295 lines) Patch
M third_party/WebKit/Source/core/dom/Node.h View 1 2 3 chunks +25 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 9 chunks +254 lines, -281 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
nainar
Running the perf bots here as an FYI
3 years, 8 months ago (2017-04-11 20:01:56 UTC) #8
nainar
On 2017/04/11 at 20:01:56, nainar wrote: > Running the perf bots here as an FYI ...
3 years, 8 months ago (2017-04-11 21:02:07 UTC) #11
shend
Hmm, that's weird, have you tried other perf bots? Moving myself to cc so it ...
3 years, 8 months ago (2017-04-12 01:02:53 UTC) #12
nainar
On 2017/04/12 at 01:02:53, shend wrote: > Hmm, that's weird, have you tried other perf ...
3 years, 8 months ago (2017-04-12 02:54:56 UTC) #14
shend
On 2017/04/12 at 02:54:56, nainar wrote: > On 2017/04/12 at 01:02:53, shend wrote: > > ...
3 years, 8 months ago (2017-04-12 02:58:08 UTC) #15
shend
3 years, 8 months ago (2017-04-12 03:12:43 UTC) #17
https://codereview.chromium.org/2813563005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/style/ComputedStyle.cpp (left):

https://codereview.chromium.org/2813563005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/style/ComputedStyle.cpp:910: *background_ !=
*other.background_)
I think it's fine to keep this, since dereferencing background would return a
StyleBackgroundData and use the == operator on it with no fast path. If you want
to change it, it should be "||" not "&&" I think.

Powered by Google App Engine
This is Rietveld 408576698