third_party/WebKit/Source/core/dom/Node.cpp - Issue 2813563005: Remove fast path checks that look into the Groups in ComputedStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2813563005: Remove fast path checks that look into the Groups in ComputedStyle (Closed)

Patch Set: Reintroduce comparison of objects Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Node.cpp

diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp

index b91538efcfaa7eb5ae14c5775966265e5ac000d0..bf2a5e12ca78cdb4aba7c2759446feab31b4bd62 100644

--- a/third_party/WebKit/Source/core/dom/Node.cpp

+++ b/third_party/WebKit/Source/core/dom/Node.cpp

@@ -310,10 +310,13 @@ NodeRareData& Node::EnsureRareData() {

if (HasRareData())

return *RareData();

- if (IsElementNode())

- data_.rare_data_ = ElementRareData::Create(data_.layout_object_);

- else

- data_.rare_data_ = NodeRareData::Create(data_.layout_object_);

+ if (IsElementNode()) {

+ data_.rare_data_ =

+ ElementRareData::Create(data_.layout_data_->GetLayoutObject());

+ } else {

+ data_.rare_data_ =

+ NodeRareData::Create(data_.layout_data_->GetLayoutObject());

+ }

DCHECK(data_.rare_data_);

SetFlag(kHasRareDataFlag);