Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 2813543003: Notify Blink to suppress frame requests during BeginMainFrame (Closed)

Created:
3 years, 8 months ago by alancutter (OOO until 2018)
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Notify Blink to suppress frame requests during BeginMainFrame This change fixes a performance regression where main thread frames were being continuously requested during composited animations. This is a temporary workaround that tells Blink when BeginMainFrame is active and it should not be requesting new frames for visual updates. BUG=704763 Review-Url: https://codereview.chromium.org/2791223002 Cr-Commit-Position: refs/heads/master@{#462022} (cherry picked from commit 317a8e0e26459f401312043fa99ed8e17b1b24a4) Review-Url: https://codereview.chromium.org/2813543003 . Cr-Commit-Position: refs/branch-heads/3029@{#662} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/09fcbb12123dc079d446c48158ab228d8b2f5952

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -1 line) Patch
M content/renderer/render_widget.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/PageAnimator.h View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/PageAnimator.cpp View 1 chunk +12 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewFrameWidget.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebWidget.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
alancutter (OOO until 2018)
3 years, 8 months ago (2017-04-11 04:19:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
09fcbb12123dc079d446c48158ab228d8b2f5952.

Powered by Google App Engine
This is Rietveld 408576698