Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2813543003: Notify Blink to suppress frame requests during BeginMainFrame (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 m_animationHost = WTF::makeUnique<CompositorAnimationHost>( 399 m_animationHost = WTF::makeUnique<CompositorAnimationHost>(
400 m_layerTreeView->compositorAnimationHost()); 400 m_layerTreeView->compositorAnimationHost());
401 m_page->layerTreeViewInitialized(*m_layerTreeView, nullptr); 401 m_page->layerTreeViewInitialized(*m_layerTreeView, nullptr);
402 } else { 402 } else {
403 m_isAcceleratedCompositingActive = false; 403 m_isAcceleratedCompositingActive = false;
404 m_animationHost = nullptr; 404 m_animationHost = nullptr;
405 } 405 }
406 } 406 }
407 } 407 }
408 408
409 void WebPagePopupImpl::setSuppressFrameRequestsWorkaroundFor704763Only(
410 bool suppressFrameRequests) {
411 if (!m_page)
412 return;
413 m_page->animator().setSuppressFrameRequestsWorkaroundFor704763Only(
414 suppressFrameRequests);
415 }
409 void WebPagePopupImpl::beginFrame(double lastFrameTimeMonotonic) { 416 void WebPagePopupImpl::beginFrame(double lastFrameTimeMonotonic) {
410 if (!m_page) 417 if (!m_page)
411 return; 418 return;
412 // FIXME: This should use lastFrameTimeMonotonic but doing so 419 // FIXME: This should use lastFrameTimeMonotonic but doing so
413 // breaks tests. 420 // breaks tests.
414 PageWidgetDelegate::animate(*m_page, monotonicallyIncreasingTime()); 421 PageWidgetDelegate::animate(*m_page, monotonicallyIncreasingTime());
415 } 422 }
416 423
417 void WebPagePopupImpl::willCloseLayerTreeView() { 424 void WebPagePopupImpl::willCloseLayerTreeView() {
418 if (m_page && m_layerTreeView) 425 if (m_page && m_layerTreeView)
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
601 // A WebPagePopupImpl instance usually has two references. 608 // A WebPagePopupImpl instance usually has two references.
602 // - One owned by the instance itself. It represents the visible widget. 609 // - One owned by the instance itself. It represents the visible widget.
603 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 610 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
604 // WebPagePopupImpl to close. 611 // WebPagePopupImpl to close.
605 // We need them because the closing operation is asynchronous and the widget 612 // We need them because the closing operation is asynchronous and the widget
606 // can be closed while the WebViewImpl is unaware of it. 613 // can be closed while the WebViewImpl is unaware of it.
607 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 614 return adoptRef(new WebPagePopupImpl(client)).leakRef();
608 } 615 }
609 616
610 } // namespace blink 617 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebPagePopupImpl.h ('k') | third_party/WebKit/Source/web/WebViewFrameWidget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698