Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2813533003: Add "Unicode" suffixes to some functions of WTF::String and WTF::StringImpl. (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
Yuta Kitamura
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, fmalita+watch_chromium.org, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "Unicode" suffixes to some functions of WTF::String and WTF::StringImpl. Add "Unicode" to: - String::Lower(locale) - String::Upper(locale) - StringImpl::Lower(locale) - StringImpl::Upper(locale) - StringImpl::Lower() - StringImpl::Upper() in order to make them less confusing. BUG=627682 Review-Url: https://codereview.chromium.org/2813533003 Cr-Commit-Position: refs/heads/master@{#463552} Committed: https://chromium.googlesource.com/chromium/src/+/7b30725259fd3886adc458795222dc1ee600f88e

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
tkent
yutak@, would you review this please? This CL is (relatively) small.
3 years, 8 months ago (2017-04-11 03:51:36 UTC) #6
Yuta Kitamura
LGTM. It's interesting to see Unicode capitalization depending on locale...
3 years, 8 months ago (2017-04-11 05:34:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813533003/1
3 years, 8 months ago (2017-04-11 06:13:46 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 06:27:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b30725259fd3886adc458795222...

Powered by Google App Engine
This is Rietveld 408576698