third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp - Issue 2813533003: Add "Unicode" suffixes to some functions of WTF::String and WTF::StringImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp

Issue 2813533003: Add "Unicode" suffixes to some functions of WTF::String and WTF::StringImpl. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutText.cpp ('k') | third_party/WebKit/Source/platform/wtf/text/AtomicString.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp b/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp

index eedae86ec741ab4cec30c2a9fdfdac044aa3fb0a..1a4e830c2c27c623d1a09a9b1a89f7f6c48e2399 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/CaseMappingHarfBuzzBufferFiller.cpp

@@ -32,9 +32,9 @@ CaseMappingHarfBuzzBufferFiller::CaseMappingHarfBuzzBufferFiller(

} else {

String case_mapped_text;

if (case_map_intend == CaseMapIntend::kUpperCase) {

- case_mapped_text = String(buffer, buffer_length).Upper(locale);

+ case_mapped_text = String(buffer, buffer_length).UpperUnicode(locale);

} else {

- case_mapped_text = String(buffer, buffer_length).Lower(locale);

+ case_mapped_text = String(buffer, buffer_length).LowerUnicode(locale);

}

if (case_mapped_text.length() != buffer_length) {

@@ -71,9 +71,9 @@ void CaseMappingHarfBuzzBufferFiller::FillSlowCase(

String char_by_char(&buffer[char_index], new_char_index - char_index);

String case_mapped_char;

if (case_map_intend == CaseMapIntend::kUpperCase)

- case_mapped_char = char_by_char.Upper(locale);

+ case_mapped_char = char_by_char.UpperUnicode(locale);

else

- case_mapped_char = char_by_char.Lower(locale);

+ case_mapped_char = char_by_char.LowerUnicode(locale);

for (unsigned j = 0; j < case_mapped_char.length();) {

UChar32 codepoint = 0;