[Mojo Video Capture] Switch to using Mojo structs in media/capture/mojo

[Mojo Video Capture] Switch to using Mojo structs in media/capture/mojo

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL22a.

Note: The video capture service implementation is currently in an incomplete and
outdated state and its tests are disabled. With the refactoring of the legacy
video capture stack now being complete, the next goal is to update the service
implementation and fit it into the refactored stack.

Changes in this CL:
* Removed "capture_settings" mojo structs+typemaps from
  services/video_capture/public and instead use structs in media/capture/mojo.

The changes to the service code are not really reviewable with it being in a
non-functional stage and the tests being inactive. The reason this CL is split
out from the one that makes the service and tests functional again (which will
be called CL22b, see [2]) is to keep the CL size reasonable for review.

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing
[2] https://codereview.chromium.org/2818513003

Review-Url: https://codereview.chromium.org/2813343002
Cr-Commit-Position: refs/heads/master@{#465305}
Committed: https://chromium.googlesource.com/chromium/src/+/e9cd4bcfe3c38ec54e63bf0dde8d49d58601f143

[chfremer, 2017-04-12 22:56:01]

Description was changed from

==========
[Mojo Video Capture] Switch to using Mojo structs in media/capture/mojo

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL22a.

Changes in this CL:
* Removed "capture_settings" mojo structs+typemaps from
  services/video_capture/public and instead use structs in media/capture/mojo.

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

to

==========
[Mojo Video Capture] Switch to using Mojo structs in media/capture/mojo

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL22a.

Note: The video capture service implementation is currently in an incomplete and
outdated state and its tests are disabled. With the refactoring of the legacy 
video capture stack now being complete, the next goal is to update the service 
implementation and fit it into the refactored stack.

Changes in this CL:
* Removed "capture_settings" mojo structs+typemaps from
  services/video_capture/public and instead use structs in media/capture/mojo.

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

[chfremer, 2017-04-12 23:04:50]

Patchset #1 (id:1) has been deleted

[chfremer, 2017-04-12 23:05:19]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 23:06:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chfremer, 2017-04-12 23:07:50]

Description was changed from

==========
[Mojo Video Capture] Switch to using Mojo structs in media/capture/mojo

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL22a.

Note: The video capture service implementation is currently in an incomplete and
outdated state and its tests are disabled. With the refactoring of the legacy 
video capture stack now being complete, the next goal is to update the service 
implementation and fit it into the refactored stack.

Changes in this CL:
* Removed "capture_settings" mojo structs+typemaps from
  services/video_capture/public and instead use structs in media/capture/mojo.

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
==========

to

==========
[Mojo Video Capture] Switch to using Mojo structs in media/capture/mojo

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL22a.

Note: The video capture service implementation is currently in an incomplete and
outdated state and its tests are disabled. With the refactoring of the legacy
video capture stack now being complete, the next goal is to update the service
implementation and fit it into the refactored stack.

Changes in this CL:
* Removed "capture_settings" mojo structs+typemaps from
  services/video_capture/public and instead use structs in media/capture/mojo.

The changes to the service code are not really reviewable with it being in a
non-functional stage and the tests being inactive. The reason this CL is split
out from the one that makes the service and tests functional again (which will
be called CL22b, see [2]) is to keep the CL size reasonable for review.

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2] https://codereview.chromium.org/2818513003
==========

[commit-bot: I haz the power, 2017-04-13 00:32:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 00:32:30]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[chfremer, 2017-04-14 19:19:40]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[chfremer, 2017-04-14 19:19:46]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-04-14 19:20:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chfremer, 2017-04-14 22:18:37]

chfremer@chromium.org changed reviewers:
+ emircan@chromium.org, mcasas@chromium.org

[chfremer, 2017-04-14 22:18:38]

emircan@: PTAL
mcasas@: optional review

[commit-bot: I haz the power, 2017-04-14 22:50:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-14 22:50:45]

Dry run: This issue passed the CQ dry run.

[emircan, 2017-04-17 21:02:12]

lgtm % nit

https://codereview.chromium.org/2813343002/diff/40001/services/video_capture/...
File services/video_capture/test/fake_device_unittest.cc (right):

https://codereview.chromium.org/2813343002/diff/40001/services/video_capture/...
services/video_capture/test/fake_device_unittest.cc:15: using testing::AtLeast;
I don't see AtLeast being used here.

[chfremer, 2017-04-17 21:57:54]

The CQ bit was checked by chfremer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 21:58:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chfremer, 2017-04-17 22:00:09]

chfremer@chromium.org changed reviewers:
+ tsepez@chromium.org, yzshen@chromium.org

[chfremer, 2017-04-17 22:00:10]

tsepez@: PTAL *.mojom, *struct_traits, *typemap_traits
yzshen@: Please RS chromium_bindings_configuration.gni

[Tom Sepez, 2017-04-17 22:32:50]

lgtm

[commit-bot: I haz the power, 2017-04-17 23:44:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 23:44:21]

Dry run: This issue passed the CQ dry run.

[yzshen1, 2017-04-18 18:17:13]

On 2017/04/17 22:32:50, Tom Sepez wrote:
> lgtm

chromium_bindings_configuration LGTM

[chfremer, 2017-04-18 18:18:06]

The CQ bit was checked by chfremer@chromium.org

[chfremer, 2017-04-18 18:18:06]

The patchset sent to the CQ was uploaded after l-g-t-m from emircan@chromium.org
Link to the patchset: https://codereview.chromium.org/2813343002/#ps60001
(title: "Removed extraneous AtLeast")

[commit-bot: I haz the power, 2017-04-18 18:18:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 18:52:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492539486018070,
"parent_rev": "871d538390b1c6c394176894f8b855d8b775d109", "commit_rev":
"e9cd4bcfe3c38ec54e63bf0dde8d49d58601f143"}

[commit-bot: I haz the power, 2017-04-18 18:52:36]

Description was changed from

==========
[Mojo Video Capture] Switch to using Mojo structs in media/capture/mojo

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL22a.

Note: The video capture service implementation is currently in an incomplete and
outdated state and its tests are disabled. With the refactoring of the legacy
video capture stack now being complete, the next goal is to update the service
implementation and fit it into the refactored stack.

Changes in this CL:
* Removed "capture_settings" mojo structs+typemaps from
  services/video_capture/public and instead use structs in media/capture/mojo.

The changes to the service code are not really reviewable with it being in a
non-functional stage and the tests being inactive. The reason this CL is split
out from the one that makes the service and tests functional again (which will
be called CL22b, see [2]) is to keep the CL size reasonable for review.

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2] https://codereview.chromium.org/2818513003
==========

to

==========
[Mojo Video Capture] Switch to using Mojo structs in media/capture/mojo

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL22a.

Note: The video capture service implementation is currently in an incomplete and
outdated state and its tests are disabled. With the refactoring of the legacy
video capture stack now being complete, the next goal is to update the service
implementation and fit it into the refactored stack.

Changes in this CL:
* Removed "capture_settings" mojo structs+typemaps from
  services/video_capture/public and instead use structs in media/capture/mojo.

The changes to the service code are not really reviewable with it being in a
non-functional stage and the tests being inactive. The reason this CL is split
out from the one that makes the service and tests functional again (which will
be called CL22b, see [2]) is to keep the CL size reasonable for review.

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1]
https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxs...
[2] https://codereview.chromium.org/2818513003

Review-Url: https://codereview.chromium.org/2813343002
Cr-Commit-Position: refs/heads/master@{#465305}
Committed:
https://chromium.googlesource.com/chromium/src/+/e9cd4bcfe3c38ec54e63bf0dde8d...
==========

[commit-bot: I haz the power, 2017-04-18 18:52:37]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e9cd4bcfe3c38ec54e63bf0dde8d...