Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2803483003: [Mojo Video Capture] Split interface BuildableVideoCaptureDevice (Closed)

Created:
3 years, 8 months ago by chfremer
Modified:
3 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mojo Video Capture] Split interface BuildableVideoCaptureDevice into “device launcher” and “launched device” This is a cleanup/simplification CL. This CL is supposed to be a pure refactoring. There should be no changes to existing behavior. Changes in this CL: * Split interface BuildableVideoCaptureDevice into interfaces VideoCaptureDeviceLauncher and LaunchedVideoCaptureDevice. * Split implementations accordingly. * VideoCaptureController is freed from knowledge of VideoFrameConsumerFeedbackObserver and VideoCaptureDeviceLauncher::Callbacks. * Moved mock implementations to a separate file, since they are used by more than one test. This CL is part of the Mojo Video Capture work. For the bigger picture, see [1] CL21. BUG=584797, 711754 TEST= capture_unittests --gtest_filter="*Video*" content_browsertests --gtest_filter="VideoCaptureBrowserTest.*" [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing Review-Url: https://codereview.chromium.org/2803483003 Cr-Commit-Position: refs/heads/master@{#464935} Committed: https://chromium.googlesource.com/chromium/src/+/c914815faeda1e930178e47c3458d387e30b8876

Patch Set 1 #

Total comments: 8

Patch Set 2 : Rebase to April 14 #

Patch Set 3 : Incorporated suggestions from PatchSet 1 #

Patch Set 4 : Remove fallback mechanism. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -1361 lines) Patch
M content/browser/BUILD.gn View 1 2 chunks +5 lines, -2 lines 0 comments Download
D content/browser/renderer_host/media/in_process_buildable_video_capture_device.h View 1 chunk +0 lines, -104 lines 0 comments Download
D content/browser/renderer_host/media/in_process_buildable_video_capture_device.cc View 1 chunk +0 lines, -444 lines 0 comments Download
A + content/browser/renderer_host/media/in_process_launched_video_capture_device.h View 2 chunks +11 lines, -66 lines 0 comments Download
A + content/browser/renderer_host/media/in_process_launched_video_capture_device.cc View 1 2 3 9 chunks +36 lines, -318 lines 0 comments Download
A + content/browser/renderer_host/media/in_process_video_capture_device_launcher.h View 3 chunks +19 lines, -42 lines 0 comments Download
A + content/browser/renderer_host/media/in_process_video_capture_device_launcher.cc View 1 2 9 chunks +73 lines, -231 lines 0 comments Download
M content/browser/renderer_host/media/in_process_video_capture_provider.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/media/in_process_video_capture_provider.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 2 chunks +1 line, -13 lines 0 comments Download
A content/browser/renderer_host/media/mock_video_capture_provider.h View 1 chunk +100 lines, -0 lines 0 comments Download
A content/browser/renderer_host/media/mock_video_capture_provider.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.h View 1 2 4 chunks +17 lines, -18 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 1 4 chunks +68 lines, -27 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 10 chunks +14 lines, -46 lines 0 comments Download
A content/browser/renderer_host/media/video_capture_device_launch_observer.h View 1 chunk +24 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 1 6 chunks +8 lines, -11 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_provider.h View 1 2 2 chunks +26 lines, -25 lines 0 comments Download
M content/test/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 65 (54 generated)
chfremer
emircan@: PTAL miu@: optional mcasas@: optional
3 years, 8 months ago (2017-04-10 22:41:56 UTC) #36
chfremer
On 2017/04/10 22:41:56, chfremer wrote: > emircan@: PTAL > miu@: optional > mcasas@: optional ping
3 years, 8 months ago (2017-04-14 16:01:56 UTC) #39
emircan
https://codereview.chromium.org/2803483003/diff/140001/content/browser/renderer_host/media/in_process_launched_video_capture_device.cc File content/browser/renderer_host/media/in_process_launched_video_capture_device.cc (right): https://codereview.chromium.org/2803483003/diff/140001/content/browser/renderer_host/media/in_process_launched_video_capture_device.cc#newcode54 content/browser/renderer_host/media/in_process_launched_video_capture_device.cc:54: StopAndReleaseDeviceOnDeviceThread(device_ptr, I don't think we can have this fallback. ...
3 years, 8 months ago (2017-04-14 17:19:38 UTC) #42
chfremer
PTAL https://codereview.chromium.org/2803483003/diff/140001/content/browser/renderer_host/media/in_process_launched_video_capture_device.cc File content/browser/renderer_host/media/in_process_launched_video_capture_device.cc (right): https://codereview.chromium.org/2803483003/diff/140001/content/browser/renderer_host/media/in_process_launched_video_capture_device.cc#newcode54 content/browser/renderer_host/media/in_process_launched_video_capture_device.cc:54: StopAndReleaseDeviceOnDeviceThread(device_ptr, On 2017/04/14 17:19:37, emircan wrote: > I ...
3 years, 8 months ago (2017-04-14 20:00:30 UTC) #46
emircan
https://codereview.chromium.org/2803483003/diff/140001/content/browser/renderer_host/media/in_process_launched_video_capture_device.cc File content/browser/renderer_host/media/in_process_launched_video_capture_device.cc (right): https://codereview.chromium.org/2803483003/diff/140001/content/browser/renderer_host/media/in_process_launched_video_capture_device.cc#newcode54 content/browser/renderer_host/media/in_process_launched_video_capture_device.cc:54: StopAndReleaseDeviceOnDeviceThread(device_ptr, On 2017/04/14 20:00:30, chfremer wrote: > On 2017/04/14 ...
3 years, 8 months ago (2017-04-14 20:15:21 UTC) #48
chfremer
PTAL https://codereview.chromium.org/2803483003/diff/140001/content/browser/renderer_host/media/in_process_launched_video_capture_device.cc File content/browser/renderer_host/media/in_process_launched_video_capture_device.cc (right): https://codereview.chromium.org/2803483003/diff/140001/content/browser/renderer_host/media/in_process_launched_video_capture_device.cc#newcode54 content/browser/renderer_host/media/in_process_launched_video_capture_device.cc:54: StopAndReleaseDeviceOnDeviceThread(device_ptr, On 2017/04/14 20:15:20, emircan wrote: > On ...
3 years, 8 months ago (2017-04-14 21:07:12 UTC) #52
emircan
lgtm
3 years, 8 months ago (2017-04-14 21:21:17 UTC) #55
chfremer
avi@: Please RS content/browser/BUILD.gn
3 years, 8 months ago (2017-04-14 21:26:56 UTC) #57
Avi (use Gerrit)
lgtm stampity stamp
3 years, 8 months ago (2017-04-15 00:00:58 UTC) #60
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803483003/200001
3 years, 8 months ago (2017-04-17 16:11:23 UTC) #62
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 17:10:45 UTC) #65
Message was sent while issue was closed.
Committed patchset #4 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/c914815faeda1e930178e47c3458...

Powered by Google App Engine
This is Rietveld 408576698