Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 2813203003: Fix Skia WinASan build, remove -fno-sanitize-address-use-after-scope (Closed)

Created:
3 years, 8 months ago by Reid Kleckner
Modified:
3 years, 8 months ago
Reviewers:
hans, krasin1, mmoroz
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Skia WinASan build, remove -fno-sanitize-address-use-after-scope Hopefully Skia doesn't have use-after-scope bugs on Windows, but this will at least fix the build. TBR=hans@chromium.org,krasin@chromium.org,mmoroz@chromium.org BUG=710928 Review-Url: https://codereview.chromium.org/2813203003 Cr-Commit-Position: refs/heads/master@{#464118} Committed: https://chromium.googlesource.com/chromium/src/+/f93904f5895990201c1e8df1c13352cba68ceb76

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/sanitizers/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Reid Kleckner
3 years, 8 months ago (2017-04-12 18:16:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813203003/1
3 years, 8 months ago (2017-04-12 18:18:11 UTC) #5
hans
lgtm
3 years, 8 months ago (2017-04-12 18:20:25 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-12 19:54:16 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f93904f5895990201c1e8df1c133...

Powered by Google App Engine
This is Rietveld 408576698