Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: build/config/sanitizers/BUILD.gn

Issue 2813203003: Fix Skia WinASan build, remove -fno-sanitize-address-use-after-scope (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sanitizers/BUILD.gn
diff --git a/build/config/sanitizers/BUILD.gn b/build/config/sanitizers/BUILD.gn
index ddcb49f37e3099748dbc95fb87142ef8d69026aa..f034331039269a40e5de0f0ee1be6e992bdd1874 100644
--- a/build/config/sanitizers/BUILD.gn
+++ b/build/config/sanitizers/BUILD.gn
@@ -317,7 +317,7 @@ config("asan_flags") {
cflags += [ "-fsanitize=address" ]
if (!is_mac && !is_win) {
cflags += [ "-fsanitize-address-use-after-scope" ]
- } else {
+ } else if (!is_win) {
# https://crbug.com/708707
cflags += [ "-fno-sanitize-address-use-after-scope" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698