Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2813123002: Prevent appcache creation from suborigins and sandboxed pages. (Closed)

Created:
3 years, 8 months ago by michaeln
Modified:
3 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent appcache creation from suborigins and sandboxed pages. Ignore the manifest attribute value when loading the document. BUG=696806 Review-Url: https://codereview.chromium.org/2813123002 Cr-Commit-Position: refs/heads/master@{#465043} Committed: https://chromium.googlesource.com/chromium/src/+/ee52d446e0aaea1ac7375ab3e7a916230688d4b8

Patch Set 1 #

Patch Set 2 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/DocumentTest.cpp View 1 4 chunks +61 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.h View 1 3 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
michaeln
ptal
3 years, 8 months ago (2017-04-12 01:56:07 UTC) #4
Mike West
This looks like a great thing to do! Can you add a test for this ...
3 years, 8 months ago (2017-04-12 05:03:56 UTC) #7
Mike West
(Code change LGTM, since you're a million time-zones away from me. Please add a test ...
3 years, 8 months ago (2017-04-12 05:04:33 UTC) #8
michaeln
I've added some unit tests, i'll hold off on committing to give you a chance ...
3 years, 8 months ago (2017-04-14 03:00:32 UTC) #11
Mike West
I'm OOO. I only skimmed the tests, but I trust you, and the bots are ...
3 years, 8 months ago (2017-04-14 16:10:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2813123002/20001
3 years, 8 months ago (2017-04-17 20:32:02 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-17 22:21:50 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ee52d446e0aaea1ac7375ab3e7a9...

Powered by Google App Engine
This is Rietveld 408576698