Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.h

Issue 2813123002: Prevent appcache creation from suborigins and sandboxed pages. (Closed)
Patch Set: tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.h
diff --git a/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.h b/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.h
index 6b6a617e3bcb2031ae74cf8d65096409ec2f9098..1109a3a0f06491ca346395c838541dd9465fd64b 100644
--- a/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.h
+++ b/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.h
@@ -32,6 +32,8 @@
#define ApplicationCacheHost_h
#include <memory>
+#include "base/gtest_prod_util.h"
+#include "core/CoreExport.h"
#include "platform/heap/Handle.h"
#include "platform/weborigin/KURL.h"
#include "platform/wtf/Allocator.h"
@@ -44,9 +46,9 @@ class DocumentLoader;
class ResourceRequest;
class ResourceResponse;
-class ApplicationCacheHost final
+class CORE_EXPORT ApplicationCacheHost final
: public GarbageCollectedFinalized<ApplicationCacheHost>,
- public WebApplicationCacheHostClient {
+ NON_EXPORTED_BASE(public WebApplicationCacheHostClient) {
WTF_MAKE_NONCOPYABLE(ApplicationCacheHost);
public:
@@ -214,6 +216,9 @@ class ApplicationCacheHost final
const String& error_message);
std::unique_ptr<WebApplicationCacheHost> host_;
+
+ FRIEND_TEST_ALL_PREFIXES(DocumentTest, SandboxDisablesAppCache);
+ FRIEND_TEST_ALL_PREFIXES(DocumentTest, SuboriginDisablesAppCache);
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698