Fix an issue with the bookmarks bar in Harmony where in the focus ring would paint outside the scro…

Fix an issue with the bookmarks bar in Harmony where in the focus ring would paint outside the scrollview.

The proposed fix here is to scroll the parent scrollview by the row bounds to ensure that the ring does not
paint outside the content area. There is an underlying problem here with the focus ring not getting clipped
when it tries to paint outside the parent.

The correct fix there is to notify the parents about the layer being used the focus ring which would require
them to create layers to host the child layer. Clipping can be done then.

The plan is to work on that in a subsequent patch.

BUG=665412
Review-Url: https://codereview.chromium.org/2813103002
Cr-Commit-Position: refs/heads/master@{#463923}
Committed: https://chromium.googlesource.com/chromium/src/+/7720633b71d3f5d8d3c912b93d2466a0b2972c24

[ananta, 2017-04-12 01:47:46]

ananta@chromium.org changed reviewers:
+ pkasting@chromium.org

[ananta, 2017-04-12 01:47:54]

The CQ bit was checked by ananta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 01:48:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-04-12 02:17:05]

LGTM

https://codereview.chromium.org/2813103002/diff/1/ui/views/controls/tree/tree...
File ui/views/controls/tree/tree_view.cc (right):

https://codereview.chromium.org/2813103002/diff/1/ui/views/controls/tree/tree...
ui/views/controls/tree/tree_view.cc:734: // content area.
Nit: "Bigger than the content area" is a little misleading -- rather than try to
fix this I might just condense the whole comment to "Scroll as necessary to
ensure the editor is visible."

[ananta, 2017-04-12 02:31:38]

The CQ bit was checked by ananta@chromium.org

[ananta, 2017-04-12 02:31:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2813103002/#ps20001
(title: "Update comment")

[commit-bot: I haz the power, 2017-04-12 02:31:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 02:43:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 02:43:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ananta, 2017-04-12 02:46:48]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[ananta, 2017-04-12 02:46:49]

sky for ui/views owners

https://codereview.chromium.org/2813103002/diff/1/ui/views/controls/tree/tree...
File ui/views/controls/tree/tree_view.cc (right):

https://codereview.chromium.org/2813103002/diff/1/ui/views/controls/tree/tree...
ui/views/controls/tree/tree_view.cc:734: // content area.
On 2017/04/12 02:17:05, Peter Kasting wrote:
> Nit: "Bigger than the content area" is a little misleading -- rather than try
to
> fix this I might just condense the whole comment to "Scroll as necessary to
> ensure the editor is visible."

Done.

[sky, 2017-04-12 03:42:12]

LGTM

[sky, 2017-04-12 03:42:21]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2017-04-12 03:42:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 03:48:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491968541195240,
"parent_rev": "fe14ad41443d4ea712b33f573e4cadb47ac9d0c1", "commit_rev":
"7720633b71d3f5d8d3c912b93d2466a0b2972c24"}

[commit-bot: I haz the power, 2017-04-12 03:49:27]

Description was changed from

==========
Fix an issue with the bookmarks bar in Harmony where in the focus ring would
paint outside the scrollview.

The proposed fix here is to scroll the parent scrollview by the row bounds to
ensure that the ring does not
paint outside the content area. There is an underlying problem here with the
focus ring not getting clipped
when it tries to paint outside the parent.

The correct fix there is to notify the parents about the layer being used the
focus ring which would require
them to create layers to host the child layer. Clipping can be done then.

The plan is to work on that in a subsequent patch.

BUG=665412
==========

to

==========
Fix an issue with the bookmarks bar in Harmony where in the focus ring would
paint outside the scrollview.

The proposed fix here is to scroll the parent scrollview by the row bounds to
ensure that the ring does not
paint outside the content area. There is an underlying problem here with the
focus ring not getting clipped
when it tries to paint outside the parent.

The correct fix there is to notify the parents about the layer being used the
focus ring which would require
them to create layers to host the child layer. Clipping can be done then.

The plan is to work on that in a subsequent patch.

BUG=665412

Review-Url: https://codereview.chromium.org/2813103002
Cr-Commit-Position: refs/heads/master@{#463923}
Committed:
https://chromium.googlesource.com/chromium/src/+/7720633b71d3f5d8d3c912b93d24...
==========

[commit-bot: I haz the power, 2017-04-12 03:49:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7720633b71d3f5d8d3c912b93d24...