Fix an issue with the bookmarks bar in Harmony where in the focus ring would paint outside the scro…

ui/views/controls/tree/tree_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/tree/tree_view.h"
 
 #include <algorithm>
 
 #include "base/i18n/rtl.h"
 #include "base/memory/ptr_util.h"
@@ skipping 711 matching lines @@
   gfx::Rect row_bounds = GetForegroundBoundsForNode(selected_node_);
   row_bounds.set_x(
       GetMirroredXWithWidthInView(row_bounds.x(), row_bounds.width()));
   row_bounds.set_x(row_bounds.x() + text_offset_);
   row_bounds.set_width(row_bounds.width() - text_offset_);
   row_bounds.Inset(kTextHorizontalPadding, kTextVerticalPadding);
   row_bounds.Inset(-empty_editor_size_.width() / 2,
                    -(empty_editor_size_.height() - font_list_.GetHeight()) / 2);
   // Give a little extra space for editing.
   row_bounds.set_width(row_bounds.width() + 50);
+  // The text field could be bigger than the content area of the parent. Scroll
+  // the parent by the bounds to make sure that we don't paint outside the
+  // content area.

[Peter Kasting, 2017/04/12 02:17:05]

Nit: "Bigger than the content area" is a little misleading -- rather than try to
fix this I might just condense the whole comment to "Scroll as necessary to
ensure the editor is visible."

[ananta, 2017/04/12 02:46:49]

Done.

+  ScrollRectToVisible(row_bounds);
   editor_->SetBoundsRect(row_bounds);
   editor_->Layout();
 }
 
 void TreeView::SchedulePaintForNode(InternalNode* node) {
   if (!node)
     return;  // Explicitly allow NULL to be passed in.
   SchedulePaintInRect(GetBackgroundBoundsForNode(node));
 }
 
@@ skipping 355 matching lines @@
   if (!is_expanded_)
     return max_width;
   for (int i = 0; i < child_count(); ++i) {
     max_width = std::max(max_width,
                          GetChild(i)->GetMaxWidth(indent, depth + 1));
   }
   return max_width;
 }
 
 }  // namespace views