Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2812983006: Revert "Add back "default address family" to HostResolver" (Closed)

Created:
3 years, 8 months ago by mgersh
Modified:
3 years, 8 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add back "default address family" to HostResolver" This reverts https://codereview.chromium.org/2709393007 plus parts of https://codereview.chromium.org/2711153007. https://codereview.chromium.org/2811183003 works around the IPv6 issue in a different way, so the "default address family" behavior is no longer needed. BUG=696569 Review-Url: https://codereview.chromium.org/2812983006 Cr-Commit-Position: refs/heads/master@{#464590} Committed: https://chromium.googlesource.com/chromium/src/+/25b612b22e90c4278252d91b143bca8b6460c921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -145 lines) Patch
M net/dns/host_resolver.h View 1 chunk +0 lines, -8 lines 0 comments Download
M net/dns/host_resolver.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M net/dns/host_resolver_impl.h View 2 chunks +0 lines, -7 lines 0 comments Download
M net/dns/host_resolver_impl.cc View 4 chunks +0 lines, -18 lines 0 comments Download
M net/dns/host_resolver_impl_unittest.cc View 1 chunk +0 lines, -94 lines 0 comments Download
M net/dns/mapped_host_resolver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/dns/mapped_host_resolver.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mgersh
PTAL
3 years, 8 months ago (2017-04-13 20:55:27 UTC) #2
xunjieli
On 2017/04/13 20:55:27, mgersh wrote: > PTAL lgtm. nice!
3 years, 8 months ago (2017-04-13 21:25:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812983006/1
3 years, 8 months ago (2017-04-13 21:29:16 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 22:58:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25b612b22e90c4278252d91b143b...

Powered by Google App Engine
This is Rietveld 408576698