Add back "default address family" to HostResolver

Add back "default address family" to HostResolver

Cronet unfortunately needs to provide an option to disable IPv6, because
certain older Android phones blackhole IPv6 packets when the screen is
locked. (Cronet-specific code will come in a separate commit.) This is 
mostly a revert of https://codereview.chromium.org/1163903002/ with some
logic rearranged.

BUG=696569
Review-Url: https://codereview.chromium.org/2709393007
Cr-Commit-Position: refs/heads/master@{#453651}
Committed: https://chromium.googlesource.com/chromium/src/+/3eba057d5ac5c97715df1cb89a9ad4d146f7e007

[mgersh, 2017-02-24 20:54:52]

mgersh@chromium.org changed reviewers:
+ juliatuttle@chromium.org

[mgersh, 2017-02-24 20:54:52]

PTAL. We ended up deciding we need this :(

[xunjieli, 2017-02-27 15:05:55]

On 2017/02/24 20:54:52, mgersh wrote:
> PTAL. We ended up deciding we need this :(

Drive-by: Could you open a crbug with a short description? Preferably, it should
mention why the workaround/flag is needed (and on what devices and Android
versions). Then link that bug in the code, so we know when that logic could be
safely removed.

[Julia Tuttle, 2017-02-27 15:08:11]

grumpy lgtm.

Agreed with xunjieli. Will be happy to roll this back when it's no longer
needed.

[mgersh, 2017-02-27 15:35:20]

Okay, added a link.

[mgersh, 2017-02-27 15:35:32]

The CQ bit was checked by mgersh@chromium.org

[mgersh, 2017-02-27 15:35:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
juliatuttle@chromium.org
Link to the patchset: https://codereview.chromium.org/2709393007/#ps40001
(title: "another link to bug")

[commit-bot: I haz the power, 2017-02-27 15:35:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xunjieli, 2017-02-27 15:38:36]

The CQ bit was unchecked by xunjieli@chromium.org

[xunjieli, 2017-02-27 15:41:37]

xunjieli@chromium.org changed reviewers:
+ xunjieli@chromium.org

[xunjieli, 2017-02-27 15:41:38]

Please link the bug in the CL description and include the motivation in the
description. It will be more informative than "cronet needs it" :).

https://codereview.chromium.org/2709393007/diff/40001/net/dns/host_resolver.h
File net/dns/host_resolver.h (right):

https://codereview.chromium.org/2709393007/diff/40001/net/dns/host_resolver.h...
net/dns/host_resolver.h:222: virtual void SetDefaultAddressFamily(AddressFamily
address_family) {}
Please add a NOTREACHED() here.
Mentioning Cronet in net/ is a layering volation. Please rework the comment.

https://codereview.chromium.org/2709393007/diff/40001/net/dns/host_resolver_i...
File net/dns/host_resolver_impl.h (right):

https://codereview.chromium.org/2709393007/diff/40001/net/dns/host_resolver_i...
net/dns/host_resolver_impl.h:353: // only to disable IPv6 in Cronet, and can be
removed when support for the
same here.

[mgersh, 2017-02-28 16:44:17]

Description was changed from

==========
Add back "default address family" to HostResolver

Cronet unfortunately needs to provide an option to disable IPv6.
(Cronet-specific code will come in a separate commit.) This is mostly a
revert of https://codereview.chromium.org/1163903002/ with some logic
rearranged.
==========

to

==========
Add back "default address family" to HostResolver

Cronet unfortunately needs to provide an option to disable IPv6, because
certain older Android phones blackhole IPv6 packets when the screen is locked.
(Cronet-specific code will come in a separate commit.) This is mostly a revert
of https://codereview.chromium.org/1163903002/ with some
logic rearranged.

BUG=696569
==========

[mgersh, 2017-02-28 16:45:04]

Description was changed from

==========
Add back "default address family" to HostResolver

Cronet unfortunately needs to provide an option to disable IPv6, because
certain older Android phones blackhole IPv6 packets when the screen is locked.
(Cronet-specific code will come in a separate commit.) This is mostly a revert
of https://codereview.chromium.org/1163903002/ with some
logic rearranged.

BUG=696569
==========

to

==========
Add back "default address family" to HostResolver

Cronet unfortunately needs to provide an option to disable IPv6, because
certain older Android phones blackhole IPv6 packets when the screen is
locked. (Cronet-specific code will come in a separate commit.) This is mostly a
revert of https://codereview.chromium.org/1163903002/ with some
logic rearranged.

BUG=696569
==========

[mgersh, 2017-02-28 16:45:20]

Description was changed from

==========
Add back "default address family" to HostResolver

Cronet unfortunately needs to provide an option to disable IPv6, because
certain older Android phones blackhole IPv6 packets when the screen is
locked. (Cronet-specific code will come in a separate commit.) This is mostly a
revert of https://codereview.chromium.org/1163903002/ with some
logic rearranged.

BUG=696569
==========

to

==========
Add back "default address family" to HostResolver

Cronet unfortunately needs to provide an option to disable IPv6, because
certain older Android phones blackhole IPv6 packets when the screen is
locked. (Cronet-specific code will come in a separate commit.) This is 
mostly a revert of https://codereview.chromium.org/1163903002/ with some
logic rearranged.

BUG=696569
==========

[mgersh, 2017-02-28 16:49:06]

https://codereview.chromium.org/2709393007/diff/40001/net/dns/host_resolver.h
File net/dns/host_resolver.h (right):

https://codereview.chromium.org/2709393007/diff/40001/net/dns/host_resolver.h...
net/dns/host_resolver.h:222: virtual void SetDefaultAddressFamily(AddressFamily
address_family) {}
On 2017/02/27 15:41:38, xunjieli wrote:
> Please add a NOTREACHED() here.
> Mentioning Cronet in net/ is a layering volation. Please rework the comment.

Done.

https://codereview.chromium.org/2709393007/diff/40001/net/dns/host_resolver_i...
File net/dns/host_resolver_impl.h (right):

https://codereview.chromium.org/2709393007/diff/40001/net/dns/host_resolver_i...
net/dns/host_resolver_impl.h:353: // only to disable IPv6 in Cronet, and can be
removed when support for the
On 2017/02/27 15:41:38, xunjieli wrote:
> same here.

Done.

[xunjieli, 2017-02-28 17:22:42]

On 2017/02/28 16:49:06, mgersh wrote:
> https://codereview.chromium.org/2709393007/diff/40001/net/dns/host_resolver.h
> File net/dns/host_resolver.h (right):
> 
>
https://codereview.chromium.org/2709393007/diff/40001/net/dns/host_resolver.h...
> net/dns/host_resolver.h:222: virtual void
SetDefaultAddressFamily(AddressFamily
> address_family) {}
> On 2017/02/27 15:41:38, xunjieli wrote:
> > Please add a NOTREACHED() here.
> > Mentioning Cronet in net/ is a layering volation. Please rework the comment.
> 
> Done.
> 
>
https://codereview.chromium.org/2709393007/diff/40001/net/dns/host_resolver_i...
> File net/dns/host_resolver_impl.h (right):
> 
>
https://codereview.chromium.org/2709393007/diff/40001/net/dns/host_resolver_i...
> net/dns/host_resolver_impl.h:353: // only to disable IPv6 in Cronet, and can
be
> removed when support for the
> On 2017/02/27 15:41:38, xunjieli wrote:
> > same here.
> 
> Done.

lgtm

[mgersh, 2017-02-28 17:22:56]

The CQ bit was checked by mgersh@chromium.org

[mgersh, 2017-02-28 17:22:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
juliatuttle@chromium.org
Link to the patchset: https://codereview.chromium.org/2709393007/#ps60001
(title: "comments")

[commit-bot: I haz the power, 2017-02-28 17:23:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 18:51:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488302576254720,
"parent_rev": "42a513a5f36a3aa08fd8d86baba02c6d6da4a5da", "commit_rev":
"3eba057d5ac5c97715df1cb89a9ad4d146f7e007"}

[commit-bot: I haz the power, 2017-02-28 18:51:44]

Description was changed from

==========
Add back "default address family" to HostResolver

Cronet unfortunately needs to provide an option to disable IPv6, because
certain older Android phones blackhole IPv6 packets when the screen is
locked. (Cronet-specific code will come in a separate commit.) This is 
mostly a revert of https://codereview.chromium.org/1163903002/ with some
logic rearranged.

BUG=696569
==========

to

==========
Add back "default address family" to HostResolver

Cronet unfortunately needs to provide an option to disable IPv6, because
certain older Android phones blackhole IPv6 packets when the screen is
locked. (Cronet-specific code will come in a separate commit.) This is 
mostly a revert of https://codereview.chromium.org/1163903002/ with some
logic rearranged.

BUG=696569

Review-Url: https://codereview.chromium.org/2709393007
Cr-Commit-Position: refs/heads/master@{#453651}
Committed:
https://chromium.googlesource.com/chromium/src/+/3eba057d5ac5c97715df1cb89a9a...
==========

[commit-bot: I haz the power, 2017-02-28 18:51:45]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/3eba057d5ac5c97715df1cb89a9a...