chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java - Issue 2812893002: [Reland] Use dropdown list for admin areas in pr form.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

Issue 2812893002: [Reland] Use dropdown list for admin areas in pr form. (Closed)

Patch Set: Start the time-out before the sub-key request. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

index 31756cab24b1c9f956b440f7eb04a7d4a5d7d9ea..45b3f2091d9c01b2d83dd40446a6621b9b8a090b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java

@@ -333,7 +333,7 @@ public class EditorView extends AlwaysDismissedDialog implements OnClickListener

== EditorFieldModel.INPUT_TYPE_HINT_DROPDOWN);

}

- if (useFullLine) {

+ if (useFullLine || isLastField) {

addFieldViewToEditor(mDataView, fieldModel);

} else {

// Create a LinearLayout to put it and the next view side by side.

@@ -390,8 +390,8 @@ public class EditorView extends AlwaysDismissedDialog implements OnClickListener

if (mObserverForTest != null) mObserverForTest.onPaymentRequestReadyToEdit();

}

};

- EditorDropdownField dropdownView =

- new EditorDropdownField(mContext, parent, fieldModel, prepareEditorRunnable);

+ EditorDropdownField dropdownView = new EditorDropdownField(

+ mContext, parent, fieldModel, prepareEditorRunnable, mObserverForTest);

mFieldViews.add(dropdownView);

mDropdownFields.add(dropdownView.getDropdown());