Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2812743002: Revert of Keep track in the browser of which frames have onunload and onbeforeunload handlers. (Closed)

Created:
3 years, 8 months ago by jam
Modified:
3 years, 8 months ago
Reviewers:
nasko, dcheng
CC:
chromium-reviews, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Keep track in the browser of which frames have onunload and onbeforeunload handlers. (patchset #10 id:180001 of https://codereview.chromium.org/2783723002/ ) Reason for revert: Exposed races with FrameHostMsg_DidStopLoading BUG=710062 Original issue's description: > Keep track in the browser of which frames have onunload and onbeforeunload handlers. > > This allows PlzNavigate to only pause fetching the request if it knows that the page has an onbeforeunload handler, where today it currently always goes to the renderer. This avoids delaying the network requests in the 95% cases that don't onbeforeunload handler on a process hop to the renderer. > > BUG=365039, 705559 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > R=dcheng@chromium.org, nasko@chromium.org > > Review-Url: https://codereview.chromium.org/2783723002 . > Cr-Commit-Position: refs/heads/master@{#460581} > Committed: https://chromium.googlesource.com/chromium/src/+/a2c84a7664eceb5cbeaae5bf1ec32da0060e3097 TBR=nasko@chromium.org,dcheng@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=365039, 705559 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2812743002 Cr-Commit-Position: refs/heads/master@{#463510} Committed: https://chromium.googlesource.com/chromium/src/+/4044498152ad71d05c57aee559cba6a97db82375

Patch Set 1 #

Patch Set 2 : manual merge #

Patch Set 3 : manual merge #

Patch Set 4 : manual merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -135 lines) Patch
M chrome/browser/lifetime/browser_close_manager.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/browser_side_navigation_browsertest.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_request.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 1 3 chunks +11 lines, -15 lines 0 comments Download
M content/browser/frame_host/navigator_impl_unittest.cc View 1 3 chunks +10 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 3 chunks +0 lines, -10 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 4 chunks +1 line, -33 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_browsertest.cc View 1 1 chunk +0 lines, -23 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 10 chunks +43 lines, -3 lines 0 comments Download
M content/common/frame_messages.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +0 lines, -15 lines 0 comments Download
M content/test/test_render_frame_host.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 2 3 chunks +19 lines, -3 lines 0 comments Download
M ui/views/controls/webview/web_dialog_view.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
jam
Created Revert of Keep track in the browser of which frames have onunload and onbeforeunload ...
3 years, 8 months ago (2017-04-10 22:11:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812743002/1
3 years, 8 months ago (2017-04-10 22:12:11 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/187779) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-10 22:15:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812743002/260001
3 years, 8 months ago (2017-04-10 22:53:20 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/344257) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-10 23:04:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812743002/280001
3 years, 8 months ago (2017-04-11 00:04:49 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/244876) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-11 00:19:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812743002/300001
3 years, 8 months ago (2017-04-11 00:24:49 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 03:02:37 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:300001) as
https://chromium.googlesource.com/chromium/src/+/4044498152ad71d05c57aee559cb...

Powered by Google App Engine
This is Rietveld 408576698