content/browser/browser_side_navigation_browsertest.cc - Issue 2812743002: Revert of Keep track in the browser of which frames have onunload and onbeforeunload handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_side_navigation_browsertest.cc

Issue 2812743002: Revert of Keep track in the browser of which frames have onunload and onbeforeunload handlers. (Closed)

Patch Set: manual merge Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/browser_side_navigation_browsertest.cc

diff --git a/content/browser/browser_side_navigation_browsertest.cc b/content/browser/browser_side_navigation_browsertest.cc

index 82505302ab37caaa6b4d328a3b831443eb26c78f..a551d54b53d6e7384f6bd4a3e41cc113bdfab0b0 100644

--- a/content/browser/browser_side_navigation_browsertest.cc

+++ b/content/browser/browser_side_navigation_browsertest.cc

@@ -282,10 +282,6 @@ IN_PROC_BROWSER_TEST_F(BrowserSideNavigationBrowserTest,

content::WindowedNotificationObserver close_observer(

content::NOTIFICATION_WEB_CONTENTS_DESTROYED,

content::Source<content::WebContents>(shell()->web_contents()));

- GURL url(

- "data:text/html,<html><script>window.onbeforeunload=function(e)"

- "{}</script></html>");

- NavigateToURL(shell(), url);

shell()->LoadURL(GURL("chrome://resources/css/tabs.css"));

shell()->web_contents()->DispatchBeforeUnload();

close_observer.Wait();