Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2812573004: Move unit tests for getElementFromPoint to context_menu_js_unittest. (Closed)

Created:
3 years, 8 months ago by danyao
Modified:
3 years, 8 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move unit tests for getElementFromPoint to context_menu_js_unittest. The corresponding JavaScript implementation was moved from core.js to context_menu.js in https://codereview.chromium.org/2800003002. BUG=614092 TESTED=Ran ios_web_unittest and passed. Review-Url: https://codereview.chromium.org/2812573004 Cr-Commit-Position: refs/heads/master@{#463637} Committed: https://chromium.googlesource.com/chromium/src/+/851599815cb52219eab8cf90a7a0571a683a6686

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -295 lines) Patch
M ios/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + ios/web/web_state/js/context_menu_js_unittest.mm View 8 chunks +10 lines, -117 lines 0 comments Download
M ios/web/web_state/js/core_js_unittest.mm View 3 chunks +3 lines, -178 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
danyao
3 years, 8 months ago (2017-04-10 22:38:01 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 8 months ago (2017-04-11 00:25:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812573004/1
3 years, 8 months ago (2017-04-11 14:15:56 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 15:21:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/851599815cb52219eab8cf90a7a0...

Powered by Google App Engine
This is Rietveld 408576698