Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2800003002: Pull context menu related APIs from core.js to their own file. (Closed)

Created:
3 years, 8 months ago by danyao
Modified:
3 years, 8 months ago
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pull context menu related APIs from core.js to their own file. These __gCrWeb APIs are only used in crw_context_menu_controller.mm. They are moved to a new context-menu.js file: - getElementFromPoint - suppressNextClick - getPageWidth TEST=ran ios_web_unittests locally BUG=614092 Review-Url: https://codereview.chromium.org/2800003002 Cr-Commit-Position: refs/heads/master@{#462713} Committed: https://chromium.googlesource.com/chromium/src/+/cd98b129dd88e75eee20e6614260c82642a21908

Patch Set 1 #

Patch Set 2 : git squash commit for context-menu. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -229 lines) Patch
M ios/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ios/web/web_state/js/resources/context_menu.js View 1 1 chunk +269 lines, -0 lines 0 comments Download
M ios/web/web_state/js/resources/core.js View 3 chunks +0 lines, -229 lines 0 comments Download
M ios/web/web_state/js/resources/web_bundle.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
danyao
3 years, 8 months ago (2017-04-06 22:46:09 UTC) #5
Eugene But (OOO till 7-30)
Thank you for the cleanup, lgtm! Please update CL description to fit 72 symbols.
3 years, 8 months ago (2017-04-06 22:57:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2800003002/40001
3 years, 8 months ago (2017-04-06 23:03:11 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 00:42:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cd98b129dd88e75eee20e6614260...

Powered by Google App Engine
This is Rietveld 408576698