Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2812573002: memory-infra: Reland: Fill the memory dump callback result (2/2) (Closed)

Created:
3 years, 8 months ago by hjd
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, danakj+watch_chromium.org, vmpstr+watch_chromium.org, fmeawad
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

memory-infra: Reland: Fill the memory dump callback result (2/2) Fill in the part of the memory dump result struct that applies to OS's view of Chrome when finalizing a memory dump. Was landed then reverted for a flaky test which later turned out to be unrelated. Review: https://codereview.chromium.org/2766173003/ Revert: https://codereview.chromium.org/2806553005/ BUG=703184 Review-Url: https://codereview.chromium.org/2812573002 Cr-Commit-Position: refs/heads/master@{#463228} Committed: https://chromium.googlesource.com/chromium/src/+/e649e4c348909f5e528fbccebd48fdbf69df84ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M base/trace_event/memory_dump_manager.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M base/trace_event/process_memory_dump.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
hjd
ptal, thanks!
3 years, 8 months ago (2017-04-10 10:33:03 UTC) #3
Primiano Tucci (use gerrit)
lgtm
3 years, 8 months ago (2017-04-10 11:16:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812573002/1
3 years, 8 months ago (2017-04-10 11:16:40 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 12:17:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e649e4c348909f5e528fbccebd48...

Powered by Google App Engine
This is Rietveld 408576698