Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2806553005: Revert of memory-infra: Fill the memory dump callback result (2/2) (Closed)

Created:
3 years, 8 months ago by hjd
Modified:
3 years, 8 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org, Elly Fong-Jones
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of memory-infra: Fill the memory dump callback result (2/2) (patchset #6 id:100001 of https://codereview.chromium.org/2766173003/ ) Reason for revert: Causing build failure: https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/54494 Original issue's description: > memory-infra: Fill the memory dump callback result (2/2) > > Fill in the part of the memory dump result struct > that applies to OS's view of Chrome when finalizing > a memory dump. > > BUG=703184 > > Review-Url: https://codereview.chromium.org/2766173003 > Cr-Commit-Position: refs/heads/master@{#462849} > Committed: https://chromium.googlesource.com/chromium/src/+/22fd5f0cf18a409dd72b96cb526a25a6cac88d24 TBR=primiano@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=703184 Review-Url: https://codereview.chromium.org/2806553005 Cr-Commit-Position: refs/heads/master@{#462864} Committed: https://chromium.googlesource.com/chromium/src/+/825abe65c05d62a80e5e6aabe29c9d59c4630da3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M base/trace_event/memory_dump_manager.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M base/trace_event/process_memory_dump.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
hjd
Created Revert of memory-infra: Fill the memory dump callback result (2/2)
3 years, 8 months ago (2017-04-07 15:10:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2806553005/1
3 years, 8 months ago (2017-04-07 15:10:45 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 15:12:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/825abe65c05d62a80e5e6aabe29c...

Powered by Google App Engine
This is Rietveld 408576698