MD Bookmarks: Restore any previously selected folder when clearing search

MD Bookmarks: Restore any previously selected folder when clearing search

With this change, clearing a search in the MD Bookmarks manager will
restore the folder that was selected before the search was started.
There is no other change to URL routing or page UI while a search is
active.

To achieve this, the |state.selectedFolder| variable is never set to null
-- it is now always set to the most recently selected folder.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2812493002
Cr-Commit-Position: refs/heads/master@{#463553}
Committed: https://chromium.googlesource.com/chromium/src/+/b466a02f6480a6f2823b823fc69f4f693377863e

[tsergeant, 2017-04-10 04:59:12]

Description was changed from

==========
MD Bookmarks: Restore any previously selected folder when clearing search

With this change, clearing a search in the MD Bookmarks manager will
restore the folder that was selected before the search was started.
There is no other change to URL routing or page UI while a search is
active.

To achieve this, the |state.selectedFolder| variable is never set to null
-- it is now always set to the most recently selected folder.

BUG=697706
==========

to

==========
MD Bookmarks: Restore any previously selected folder when clearing search

With this change, clearing a search in the MD Bookmarks manager will
restore the folder that was selected before the search was started.
There is no other change to URL routing or page UI while a search is
active.

To achieve this, the |state.selectedFolder| variable is never set to null
-- it is now always set to the most recently selected folder.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-04-10 04:59:24]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 04:59:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-04-10 05:01:57]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-04-10 05:01:57]

As requested. The selected folder doesn't show up in the url when a search is
active, because I still think that's kinda silly.

[commit-bot: I haz the power, 2017-04-10 06:02:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 06:02:51]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-04-11 05:05:09]

lgtm.

https://codereview.chromium.org/2812493002/diff/1/chrome/test/data/webui/md_b...
File chrome/test/data/webui/md_bookmarks/reducers_test.js (right):

https://codereview.chromium.org/2812493002/diff/1/chrome/test/data/webui/md_b...
chrome/test/data/webui/md_bookmarks/reducers_test.js:389: // UI changes once
search results arrive:
micro-nit: : => .

[tsergeant, 2017-04-11 05:30:32]

https://codereview.chromium.org/2812493002/diff/1/chrome/test/data/webui/md_b...
File chrome/test/data/webui/md_bookmarks/reducers_test.js (right):

https://codereview.chromium.org/2812493002/diff/1/chrome/test/data/webui/md_b...
chrome/test/data/webui/md_bookmarks/reducers_test.js:389: // UI changes once
search results arrive:
On 2017/04/11 05:05:09, calamity wrote:
> micro-nit: : => .

Done.

[tsergeant, 2017-04-11 05:30:38]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2017-04-11 05:30:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2812493002/#ps20001
(title: "Fix comment")

[commit-bot: I haz the power, 2017-04-11 05:31:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 06:29:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491888638094430,
"parent_rev": "7b30725259fd3886adc458795222dc1ee600f88e", "commit_rev":
"b466a02f6480a6f2823b823fc69f4f693377863e"}

[commit-bot: I haz the power, 2017-04-11 06:30:06]

Description was changed from

==========
MD Bookmarks: Restore any previously selected folder when clearing search

With this change, clearing a search in the MD Bookmarks manager will
restore the folder that was selected before the search was started.
There is no other change to URL routing or page UI while a search is
active.

To achieve this, the |state.selectedFolder| variable is never set to null
-- it is now always set to the most recently selected folder.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Restore any previously selected folder when clearing search

With this change, clearing a search in the MD Bookmarks manager will
restore the folder that was selected before the search was started.
There is no other change to URL routing or page UI while a search is
active.

To achieve this, the |state.selectedFolder| variable is never set to null
-- it is now always set to the most recently selected folder.

BUG=697706
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2812493002
Cr-Commit-Position: refs/heads/master@{#463553}
Committed:
https://chromium.googlesource.com/chromium/src/+/b466a02f6480a6f2823b823fc69f...
==========

[commit-bot: I haz the power, 2017-04-11 06:30:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b466a02f6480a6f2823b823fc69f...