Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7341)

Unified Diff: chrome/browser/resources/md_bookmarks/reducers.js

Issue 2812493002: MD Bookmarks: Restore any previously selected folder when clearing search (Closed)
Patch Set: Fix comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/reducers.js
diff --git a/chrome/browser/resources/md_bookmarks/reducers.js b/chrome/browser/resources/md_bookmarks/reducers.js
index b5cfabe3c9bde4141b27aa4f5bedbffa8aa18112..b0d0a9267ba9acae843c3e8e6ce32962a99ce430 100644
--- a/chrome/browser/resources/md_bookmarks/reducers.js
+++ b/chrome/browser/resources/md_bookmarks/reducers.js
@@ -304,10 +304,10 @@ cr.define('bookmarks', function() {
};
/**
- * @param {?string} selectedFolder
+ * @param {string} selectedFolder
* @param {Action} action
* @param {NodeList} nodes
- * @return {?string}
+ * @return {string}
*/
SelectedFolderState.updateSelectedFolder = function(
selectedFolder, action, nodes) {
@@ -324,12 +324,6 @@ cr.define('bookmarks', function() {
return action.id;
}
return selectedFolder;
- case 'finish-search':
- return null;
- case 'clear-search':
- // TODO(tsergeant): Return to the folder that was selected before the
- // search.
- return nodes[ROOT_NODE_ID].children[0];
case 'remove-bookmark':
// When deleting the selected folder (or its ancestor), select the
// parent of the deleted node.
« no previous file with comments | « chrome/browser/resources/md_bookmarks/folder_node.js ('k') | chrome/browser/resources/md_bookmarks/types.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698