Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2812473002:
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/quota (Closed)
|
Created:
3 years, 8 months ago by Hwanseung Lee Modified:
3 years, 8 months ago CC:
blink-reviews, chromium-reviews, kinuko+fileapi, nhiroki, tzik Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionReplace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/quota
Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED
with DCHECK_op, CHECK_op, and NOTREACHED respectively in
third_party/WebKit/Source/modules/quota
BUG=707641
Review-Url: https://codereview.chromium.org/2812473002
Cr-Commit-Position: refs/heads/master@{#463163}
Committed: https://chromium.googlesource.com/chromium/src/+/718823aa31aecf6aad1751407ac2c55ce26cf88e
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 25 (17 generated)
Description was changed from ========== Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/quota Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/modules/quota BUG=707641 ========== to ========== Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/quota Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/modules/quota BUG=707641 ==========
hs1217.lee@samsung.com changed reviewers: + kinuko@chromium.org, tkent@chromium.org
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
PTAL, thank you.
LGTM
The CQ bit was checked by hs1217.lee@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
tkent@chromium.org changed reviewers: + haraken@chromium.org
Please rebase.
The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hs1217.lee@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2812473002/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491787466292690,
"parent_rev": "5136172049cbea062e1dcf86fa41fceef13183c3", "commit_rev":
"718823aa31aecf6aad1751407ac2c55ce26cf88e"}
Message was sent while issue was closed.
Description was changed from ========== Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/quota Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/modules/quota BUG=707641 ========== to ========== Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/quota Replace ASSERT, RELEASE_ASSERT, and ASSERT_NOT_REACHED with DCHECK_op, CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/modules/quota BUG=707641 Review-Url: https://codereview.chromium.org/2812473002 Cr-Commit-Position: refs/heads/master@{#463163} Committed: https://chromium.googlesource.com/chromium/src/+/718823aa31aecf6aad1751407ac2... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/718823aa31aecf6aad1751407ac2... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
