third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp - Issue 2812473002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/quota

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp

Issue 2812473002: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in modules/quota (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp

diff --git a/third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp b/third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp

index d97d2bcd6a0162aba619de1bf84b5fd657dedafc..ed0f0e4f94f0af9b65690b455622ea94a2d5559f 100644

--- a/third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp

+++ b/third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp

@@ -56,7 +56,7 @@ void DeprecatedStorageQuota::queryUsageAndQuota(

StorageUsageCallback* success_callback,

StorageErrorCallback* error_callback) {

ExecutionContext* execution_context = script_state->GetExecutionContext();

- ASSERT(execution_context);

+ DCHECK(execution_context);

WebStorageQuotaType storage_type = static_cast<WebStorageQuotaType>(type_);

if (storage_type != kWebStorageQuotaTypeTemporary &&

@@ -90,7 +90,7 @@ void DeprecatedStorageQuota::requestQuota(