[ios clean] Creates ToolsMenu UnitTests

[ios clean] ToolsMenu UnitTests

Adds a simple test for the mediator and creates a placeholder test file for the coordinator.

BUG=682880
Review-Url: https://codereview.chromium.org/2812463002
Cr-Commit-Position: refs/heads/master@{#464247}
Committed: https://chromium.googlesource.com/chromium/src/+/1a103411c274920f778226cd05370003edf85047

[sczs, 2017-04-10 02:58:56]

Description was changed from

==========
[ios clean] ToolsMenu UnitTests

BUG=682880
==========

to

==========
[ios clean] ToolsMenu UnitTests

Adds a simple test for the mediator and creates a placeholder test file for the
coordinator.

BUG=682880
==========

[sczs, 2017-04-10 02:58:56]

sczs@chromium.org changed reviewers:
+ edchin@chromium.org, lpromero@chromium.org, marq@chromium.org

[sczs, 2017-04-10 02:59:14]

PTAL

[edchin, 2017-04-10 05:56:28]

https://codereview.chromium.org/2812463002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm (right):

https://codereview.chromium.org/2812463002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm:20:
ToolsMediatorTest() {}
Delete if there's nothing to put here.

https://codereview.chromium.org/2812463002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm:23: ToolsMediator*
mediator_;
protected:

[sczs, 2017-04-10 20:54:19]

https://codereview.chromium.org/2812463002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm (right):

https://codereview.chromium.org/2812463002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm:20:
ToolsMediatorTest() {}
On 2017/04/10 05:56:28, edchin wrote:
> Delete if there's nothing to put here.

Done.

https://codereview.chromium.org/2812463002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/tools/tools_mediator_unittest.mm:23: ToolsMediator*
mediator_;
On 2017/04/10 05:56:28, edchin wrote:
> protected:

Done.

[edchin, 2017-04-10 21:16:11]

lgtm.

https://codereview.chromium.org/2812463002/diff/20001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/ui/tools/BUILD.gn (right):

https://codereview.chromium.org/2812463002/diff/20001/ios/clean/chrome/browse...
ios/clean/chrome/browser/ui/tools/BUILD.gn:62: "//base",
I don't think you need this.

[marq (ping after 24h), 2017-04-12 11:41:32]

lgtm

[lpromero, 2017-04-12 13:44:39]

lgtm

https://codereview.chromium.org/2812463002/diff/20001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/ui/tools/tools_coordinator_unittest.mm (right):

https://codereview.chromium.org/2812463002/diff/20001/ios/clean/chrome/browse...
ios/clean/chrome/browser/ui/tools/tools_coordinator_unittest.mm:9: #endif
Anything you could test here? Maybe that the view controller and mediators are
properly created, and that the view controller is the consumer of the mediator?

[sczs, 2017-04-12 20:10:11]

https://codereview.chromium.org/2812463002/diff/20001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/ui/tools/BUILD.gn (right):

https://codereview.chromium.org/2812463002/diff/20001/ios/clean/chrome/browse...
ios/clean/chrome/browser/ui/tools/BUILD.gn:62: "//base",
On 2017/04/10 21:16:11, edchin wrote:
> I don't think you need this. 

Good catch! Done!

https://codereview.chromium.org/2812463002/diff/20001/ios/clean/chrome/browse...
File ios/clean/chrome/browser/ui/tools/tools_coordinator_unittest.mm (right):

https://codereview.chromium.org/2812463002/diff/20001/ios/clean/chrome/browse...
ios/clean/chrome/browser/ui/tools/tools_coordinator_unittest.mm:9: #endif
On 2017/04/12 13:44:39, lpromero wrote:
> Anything you could test here? Maybe that the view controller and mediators are
> properly created, and that the view controller is the consumer of the
mediator?

Great idea! I was trying to do that but I need to Fake the dispatcher and
Browser class in order to get the Coordinator started. 
Will leave that to a future CL since everyone lgtm'ed this already.

[sczs, 2017-04-12 20:10:50]

The CQ bit was checked by sczs@chromium.org

[sczs, 2017-04-12 20:10:51]

The patchset sent to the CQ was uploaded after l-g-t-m from edchin@chromium.org,
marq@chromium.org, lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2812463002/#ps40001
(title: "Remove unused dep")

[commit-bot: I haz the power, 2017-04-12 20:11:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 21:50:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 21:50:55]

Failed to apply patch for ios/clean/chrome/test/BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: ios/clean/chrome/test/BUILD.gn:26
  Falling back to three-way merge...
  Applied patch to 'ios/clean/chrome/test/BUILD.gn' with conflicts.
  U ios/clean/chrome/test/BUILD.gn

Patch:       ios/clean/chrome/test/BUILD.gn
Index: ios/clean/chrome/test/BUILD.gn
diff --git a/ios/clean/chrome/test/BUILD.gn b/ios/clean/chrome/test/BUILD.gn
index
4c59abcbcffc4a60df0de994e6c8f85f8c81d5a9..380a8e9ea60a89cde1f361373589f73819f24402
100644
--- a/ios/clean/chrome/test/BUILD.gn
+++ b/ios/clean/chrome/test/BUILD.gn
@@ -26,6 +26,7 @@ test("ios_clean_chrome_unittests") {
     "//ios/clean/chrome/browser/ui/recent_tabs:unit_tests",
     "//ios/clean/chrome/browser/ui/tab_collection:unit_tests",
     "//ios/clean/chrome/browser/ui/tab_grid:unit_tests",
+    "//ios/clean/chrome/browser/ui/tools:unit_tests",
     "//ios/clean/chrome/browser/ui/web_contents:unit_tests",
   ]
 }

[sczs, 2017-04-12 23:09:03]

The CQ bit was checked by sczs@chromium.org

[sczs, 2017-04-12 23:09:03]

The patchset sent to the CQ was uploaded after l-g-t-m from edchin@chromium.org,
marq@chromium.org, lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2812463002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-12 23:10:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 02:14:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492038543451700,
"parent_rev": "67caee99605db7a1bde5ea88de2f8425672b0931", "commit_rev":
"1a103411c274920f778226cd05370003edf85047"}

[commit-bot: I haz the power, 2017-04-13 02:14:49]

Description was changed from

==========
[ios clean] ToolsMenu UnitTests

Adds a simple test for the mediator and creates a placeholder test file for the
coordinator.

BUG=682880
==========

to

==========
[ios clean] ToolsMenu UnitTests

Adds a simple test for the mediator and creates a placeholder test file for the
coordinator.

BUG=682880

Review-Url: https://codereview.chromium.org/2812463002
Cr-Commit-Position: refs/heads/master@{#464247}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a103411c274920f778226cd0537...
==========

[commit-bot: I haz the power, 2017-04-13 02:14:51]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1a103411c274920f778226cd0537...