ios/clean/chrome/browser/ui/tools/tools_coordinator_unittest.mm - Issue 2812463002: [ios clean] Creates ToolsMenu UnitTests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/clean/chrome/browser/ui/tools/tools_coordinator_unittest.mm

Issue 2812463002: [ios clean] Creates ToolsMenu UnitTests (Closed)

Patch Set: CL Feedback Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #import "ios/clean/chrome/browser/ui/tools/tools_coordinator.h"

	6

	7 #if !defined(__has_feature) \|\| !__has_feature(objc_arc)

	8 #error "This file requires ARC support."

	9 #endif
	lpromero 2017/04/12 13:44:39 Anything you could test here? Maybe that the view Anything you could test here? Maybe that the view controller and mediators are properly created, and that the view controller is the consumer of the mediator? sczs 2017/04/12 20:10:11 Great idea! I was trying to do that but I need to Show quoted text On 2017/04/12 13:44:39, lpromero wrote: > Anything you could test here? Maybe that the view controller and mediators are > properly created, and that the view controller is the consumer of the mediator? Great idea! I was trying to do that but I need to Fake the dispatcher and Browser class in order to get the Coordinator started. Will leave that to a future CL since everyone lgtm'ed this already.
OLD	NEW