Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2812343002: Revert of MD-Settings: A11y - Make sure checked is reflected. (Closed)

Created:
3 years, 8 months ago by Dan Beam
Modified:
3 years, 8 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MD-Settings: A11y - Make sure checked is reflected. (patchset #1 id:1 of https://codereview.chromium.org/2809033002/ ) Reason for revert: Breaks "On Startup" radio group by allowing the effective value to become unchecked http://i.imgur.com/FUjYU7Q.png Original issue's description: > MD-Settings: A11y - Make sure checked is reflected. > > R=dbeam@chromium.org > BUG=709579 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2809033002 > Cr-Commit-Position: refs/heads/master@{#463677} > Committed: https://chromium.googlesource.com/chromium/src/+/6dd419deb677011673257d555f097cbc944adc28 TBR=hcarmona@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=709579 Review-Url: https://codereview.chromium.org/2812343002 Cr-Commit-Position: refs/heads/master@{#464128} Committed: https://chromium.googlesource.com/chromium/src/+/8cc56536e49b90e770e701868a5941ed53a07737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/controls/controlled_radio_button.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Dan Beam
Created Revert of MD-Settings: A11y - Make sure checked is reflected.
3 years, 8 months ago (2017-04-12 18:34:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812343002/1
3 years, 8 months ago (2017-04-12 18:35:41 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/8cc56536e49b90e770e701868a5941ed53a07737
3 years, 8 months ago (2017-04-12 20:12:29 UTC) #6
hcarmona
3 years, 8 months ago (2017-04-12 22:43:19 UTC) #7
Message was sent while issue was closed.
lgtm

Do you want me to update + reland or will your changes to the radio button for
"x of y" make this unnecessary?

Powered by Google App Engine
This is Rietveld 408576698