MD-Settings: A11y - Make sure checked is reflected.

MD-Settings: A11y - Make sure checked is reflected.

R=dbeam@chromium.org
BUG=709579
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2809033002
Cr-Commit-Position: refs/heads/master@{#463677}
Committed: https://chromium.googlesource.com/chromium/src/+/6dd419deb677011673257d555f097cbc944adc28

[hcarmona, 2017-04-10 23:38:49]

Description was changed from

==========
MD-Settings: A11y - Make sure checked is reflected.

R=dbeam@chromium.org
BUG=709579
==========

to

==========
MD-Settings: A11y - Make sure checked is reflected.

R=dbeam@chromium.org
BUG=709579
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2017-04-10 23:38:51]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 23:39:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2017-04-10 23:39:47]

Missing $ fixes a11y issue w/ "selected" not being communicated to user.

[Dan Beam, 2017-04-10 23:44:38]

lgtm

[hcarmona, 2017-04-10 23:45:30]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2017-04-10 23:45:31]

The CQ bit was unchecked by hcarmona@chromium.org

[Dan Beam, 2017-04-11 06:00:50]

btw, why does this matter?

the property being set has `reflectToAttribute: true`

https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chro...

[Dan Beam, 2017-04-11 06:55:01]

On 2017/04/11 06:00:50, Dan Beam wrote:
> btw, why does this matter?
> 
> the property being set has `reflectToAttribute: true`
> 
>
https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chro...

actually, I take it back: I don't care how this works.

[hcarmona, 2017-04-11 17:28:42]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2017-04-11 17:29:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 17:46:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491931722698570, "parent_rev":
"962e229d691dec944dd65991f39ab18ebb0292ae", "commit_rev":
"6dd419deb677011673257d555f097cbc944adc28"}

[commit-bot: I haz the power, 2017-04-11 17:47:33]

Description was changed from

==========
MD-Settings: A11y - Make sure checked is reflected.

R=dbeam@chromium.org
BUG=709579
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD-Settings: A11y - Make sure checked is reflected.

R=dbeam@chromium.org
BUG=709579
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2809033002
Cr-Commit-Position: refs/heads/master@{#463677}
Committed:
https://chromium.googlesource.com/chromium/src/+/6dd419deb677011673257d555f09...
==========

[commit-bot: I haz the power, 2017-04-11 17:47:34]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6dd419deb677011673257d555f09...

[Dan Beam, 2017-04-12 18:34:50]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2812343002/ by dbeam@chromium.org.

The reason for reverting is: Breaks "On Startup" radio group by allowing the
effective value to become unchecked

http://i.imgur.com/FUjYU7Q.png.