Unit test FindInPageMediator.

Unit test FindInPageMediator.

BUG=none
R=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2812133004
Cr-Commit-Position: refs/heads/master@{#464389}
Committed: https://chromium.googlesource.com/chromium/src/+/6119a2799c7a3b02abf1a97b188c4f273144cee6

[lpromero, 2017-04-13 00:09:07]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[lpromero, 2017-04-13 00:10:14]

This simple test is failing due to the fact that the observer is never removed:

[----------] 1 test from FindInPageMediatorTest
[ RUN      ] FindInPageMediatorTest.Init
[38591:1027:0413/015404.471113:82895182248678:FATAL:observer_list.h(338)] Check
failed: ObserverListBase<ObserverType>::size() == 0U (1 vs. 0)

[commit-bot: I haz the power, 2017-04-13 00:10:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2017-04-13 00:19:36]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 00:20:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2017-04-13 00:20:46]

On 2017/04/13 00:10:14, lpromero wrote:
> This simple test is failing due to the fact that the observer is never
removed:
> 
> [----------] 1 test from FindInPageMediatorTest
> [ RUN      ] FindInPageMediatorTest.Init
> [38591:1027:0413/015404.471113:82895182248678:FATAL:observer_list.h(338)]
Check
> failed: ObserverListBase<ObserverType>::size() == 0U (1 vs. 0)

Patchset 2 proposes a fix. It could be more involved like
https://cs.chromium.org/chromium/src/ios/clean/chrome/browser/ui/tab_collecti...

[lpromero, 2017-04-13 00:26:21]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 00:27:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 01:48:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 01:48:55]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-04-13 12:47:54]

lgtm

[lpromero, 2017-04-13 13:01:57]

The CQ bit was checked by lpromero@chromium.org

[commit-bot: I haz the power, 2017-04-13 13:02:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 13:05:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492088517946320,
"parent_rev": "4901e4ce3bcd49618d8b788f1a67c5276a4147fb", "commit_rev":
"6119a2799c7a3b02abf1a97b188c4f273144cee6"}

[commit-bot: I haz the power, 2017-04-13 13:06:47]

Description was changed from

==========
Unit test FindInPageMediator.

BUG=none
R=rohitrao@chromium.org
==========

to

==========
Unit test FindInPageMediator.

BUG=none
R=rohitrao@chromium.org

Review-Url: https://codereview.chromium.org/2812133004
Cr-Commit-Position: refs/heads/master@{#464389}
Committed:
https://chromium.googlesource.com/chromium/src/+/6119a2799c7a3b02abf1a97b188c...
==========

[commit-bot: I haz the power, 2017-04-13 13:06:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6119a2799c7a3b02abf1a97b188c...