ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm - Issue 2812133004: Unit test FindInPageMediator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm

Issue 2812133004: Unit test FindInPageMediator. (Closed)

Patch Set: Rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm

diff --git a/ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm b/ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm

index c3a269a10e561e1b0784eb0709b6dca6d9131c5f..c5f7900e326ac1958ddfbd7fda30af0f22da5f22 100644

--- a/ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm

+++ b/ios/clean/chrome/browser/ui/find_in_page/find_in_page_mediator.mm

@@ -60,6 +60,10 @@

return self;

}

+- (void)dealloc {

+ _webStateList->RemoveObserver(_webStateListObserver.get());

- (void)stopFinding {

web::WebState* webState = self.webStateList->GetActiveWebState();

FindTabHelper* helper = FindTabHelper::FromWebState(webState);