Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2812103002: Don't allow the composited-alpha folding optimization to cross subsequences (Closed)

Created:
3 years, 8 months ago by chrishtr
Modified:
3 years, 8 months ago
Reviewers:
wkorman
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't allow the composited-alpha folding optimization to cross subsequences. Otherwise the subsequence indices will become broken. This worked before https://codereview.chromium.org/2793233002 because the EndSubsequenceDisplayItem would always get in the way of the DrawingDisplayItem and its preceding BeginCompositingDisplayItem. Now do the same thing by keeping track of the last place such an end would have been. BUG=709962 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2812103002 Cr-Commit-Position: refs/heads/master@{#463810} Committed: https://chromium.googlesource.com/chromium/src/+/4b7d450be9fdfdc87a50c718053628da03ef243e

Patch Set 1 #

Patch Set 2 : none #

Total comments: 7

Patch Set 3 : none #

Patch Set 4 : none #

Messages

Total messages: 17 (11 generated)
chrishtr
3 years, 8 months ago (2017-04-11 20:15:54 UTC) #5
wkorman
https://codereview.chromium.org/2812103002/diff/20001/third_party/WebKit/LayoutTests/paint/transparency/compositing-alpha-fold-crash.html File third_party/WebKit/LayoutTests/paint/transparency/compositing-alpha-fold-crash.html (right): https://codereview.chromium.org/2812103002/diff/20001/third_party/WebKit/LayoutTests/paint/transparency/compositing-alpha-fold-crash.html#newcode3 third_party/WebKit/LayoutTests/paint/transparency/compositing-alpha-fold-crash.html:3: <body style="opacity: 0.5"> rm space? https://codereview.chromium.org/2812103002/diff/20001/third_party/WebKit/LayoutTests/paint/transparency/compositing-alpha-fold-crash.html#newcode4 third_party/WebKit/LayoutTests/paint/transparency/compositing-alpha-fold-crash.html:4: <div id=div1 ...
3 years, 8 months ago (2017-04-11 20:52:25 UTC) #7
chrishtr
https://codereview.chromium.org/2812103002/diff/20001/third_party/WebKit/LayoutTests/paint/transparency/compositing-alpha-fold-crash.html File third_party/WebKit/LayoutTests/paint/transparency/compositing-alpha-fold-crash.html (right): https://codereview.chromium.org/2812103002/diff/20001/third_party/WebKit/LayoutTests/paint/transparency/compositing-alpha-fold-crash.html#newcode3 third_party/WebKit/LayoutTests/paint/transparency/compositing-alpha-fold-crash.html:3: <body style="opacity: 0.5"> On 2017/04/11 at 20:52:25, wkorman wrote: ...
3 years, 8 months ago (2017-04-11 21:09:10 UTC) #8
wkorman
lgtm
3 years, 8 months ago (2017-04-11 21:15:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2812103002/60001
3 years, 8 months ago (2017-04-11 21:19:37 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 22:41:55 UTC) #17
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4b7d450be9fdfdc87a50c7180536...

Powered by Google App Engine
This is Rietveld 408576698