Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/CompositingRecorder.cpp

Issue 2812103002: Don't allow the composited-alpha folding optimization to cross subsequences (Closed)
Patch Set: none Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/CompositingRecorder.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/CompositingRecorder.cpp b/third_party/WebKit/Source/platform/graphics/paint/CompositingRecorder.cpp
index e39babd880e4d365accf9c76f7e70f7c1e7a0b71..cdcd8fd07f413cf43f16af7211cc5f8df50797f1 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/CompositingRecorder.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/CompositingRecorder.cpp
@@ -40,10 +40,13 @@ CompositingRecorder::~CompositingRecorder() {
const DisplayItem* last_display_item = paint_controller.LastDisplayItem(0);
const DisplayItem* second_to_last_display_item =
paint_controller.LastDisplayItem(1);
+ // TODO(chrishtr): remove the call to LastDisplayItemIsSubsequenceEnd when
+ // https://codereview.chromium.org/2768143002 lands.
if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled() && last_display_item &&
second_to_last_display_item && last_display_item->DrawsContent() &&
second_to_last_display_item->GetType() ==
- DisplayItem::kBeginCompositing) {
+ DisplayItem::kBeginCompositing &&
+ !paint_controller.LastDisplayItemIsSubsequenceEnd()) {
FloatRect cull_rect(
((DrawingDisplayItem*)last_display_item)->GetPaintRecord()->cullRect());
const DisplayItemClient& display_item_client = last_display_item->Client();

Powered by Google App Engine
This is Rietveld 408576698