No-op when starting a started coordinator (ditto for stop).

No-op when starting a started coordinator (ditto for stop).

BUG=none
R=marq@chromium.org
CC=rohitrao@chromium.org,sczs@chromium.org,edchin@chromium.org,justincohen@chromium.org

Review-Url: https://codereview.chromium.org/2811973004
Cr-Commit-Position: refs/heads/master@{#464546}
Committed: https://chromium.googlesource.com/chromium/src/+/2732c7ec9e18fe11eff9d9c1a1bae1d57c6252d7

[lpromero, 2017-04-12 17:32:07]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 17:33:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 17:54:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 17:54:13]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[lpromero, 2017-04-12 21:23:01]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 21:23:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 22:32:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 22:32:25]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[lpromero, 2017-04-13 13:29:48]

Mutually exclusive with https://codereview.chromium.org/2815323002.

[lpromero, 2017-04-13 13:36:47]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 13:37:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 14:32:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 14:32:49]

Dry run: This issue passed the CQ dry run.

[marq (ping after 24h), 2017-04-13 15:11:51]

lgtm

https://codereview.chromium.org/2811973004/diff/40001/ios/shared/chrome/brows...
File ios/shared/chrome/browser/ui/coordinators/browser_coordinator.h (right):

https://codereview.chromium.org/2811973004/diff/40001/ios/shared/chrome/brows...
ios/shared/chrome/browser/ui/coordinators/browser_coordinator.h:33: // Starting
a started coordinator is a no-op.
So: subclasses only need to call [super start] if they haven't started, so this
general form:

- (void)start {
  if (self.started) return;
  ...
  [super start]
}

is always OK.

[lpromero, 2017-04-13 20:56:49]

The CQ bit was checked by lpromero@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-13 20:57:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpromero, 2017-04-13 20:57:34]

Thanks!

https://codereview.chromium.org/2811973004/diff/40001/ios/shared/chrome/brows...
File ios/shared/chrome/browser/ui/coordinators/browser_coordinator.h (right):

https://codereview.chromium.org/2811973004/diff/40001/ios/shared/chrome/brows...
ios/shared/chrome/browser/ui/coordinators/browser_coordinator.h:33: // Starting
a started coordinator is a no-op.
On 2017/04/13 15:11:51, marq wrote:
> So: subclasses only need to call [super start] if they haven't started, so
this
> general form:
> 
> - (void)start {
>   if (self.started) return;
>   ...
>   [super start]
> }
> 
> is always OK. 

Done.

[lpromero, 2017-04-13 20:57:42]

The CQ bit was unchecked by lpromero@chromium.org

[lpromero, 2017-04-13 20:57:47]

The CQ bit was checked by lpromero@chromium.org

[lpromero, 2017-04-13 20:57:47]

The patchset sent to the CQ was uploaded after l-g-t-m from marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2811973004/#ps60001
(title: "Update doc")

[commit-bot: I haz the power, 2017-04-13 20:58:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 21:12:55]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492117067098580,
"parent_rev": "1d4021fa979a172a4509d6212655c39c1fe6a791", "commit_rev":
"2732c7ec9e18fe11eff9d9c1a1bae1d57c6252d7"}

[commit-bot: I haz the power, 2017-04-13 21:13:47]

Description was changed from

==========
No-op when starting a started coordinator (ditto for stop).

BUG=none
R=marq@chromium.org
CC=rohitrao@chromium.org,sczs@chromium.org,edchin@chromium.org,justincohen@ch...
==========

to

==========
No-op when starting a started coordinator (ditto for stop).

BUG=none
R=marq@chromium.org
CC=rohitrao@chromium.org,sczs@chromium.org,edchin@chromium.org,justincohen@ch...

Review-Url: https://codereview.chromium.org/2811973004
Cr-Commit-Position: refs/heads/master@{#464546}
Committed:
https://chromium.googlesource.com/chromium/src/+/2732c7ec9e18fe11eff9d9c1a1ba...
==========

[commit-bot: I haz the power, 2017-04-13 21:13:48]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/2732c7ec9e18fe11eff9d9c1a1ba...