Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Unified Diff: ios/shared/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm

Issue 2811973004: No-op when starting a started coordinator (ditto for stop). (Closed)
Patch Set: Update doc Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/shared/chrome/browser/ui/coordinators/browser_coordinator.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/shared/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm
diff --git a/ios/shared/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm b/ios/shared/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm
index 354f2875d3dee947520074ef8cc80c29ea765853..b5a171d9c0aabb24b40af599420bbdcfcbacf92b 100644
--- a/ios/shared/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm
+++ b/ios/shared/chrome/browser/ui/coordinators/browser_coordinator_unittest.mm
@@ -209,7 +209,7 @@ TEST(BrowserCoordinatorTest, StopStopsStartedChildren) {
EXPECT_TRUE(called);
}
-TEST(BrowserCoordinatorTest, StopDoesntStopNonStartedChildren) {
+TEST(BrowserCoordinatorTest, StopStopsNonStartedChildren) {
TestCoordinator* parent = [[TestCoordinator alloc] init];
TestCoordinator* child = [[TestCoordinator alloc] init];
[parent addChildCoordinator:child];
@@ -224,7 +224,7 @@ TEST(BrowserCoordinatorTest, StopDoesntStopNonStartedChildren) {
[parent stop];
// It should not have called stop on the child.
- EXPECT_FALSE(called);
+ EXPECT_TRUE(called);
}
} // namespace
« no previous file with comments | « ios/shared/chrome/browser/ui/coordinators/browser_coordinator.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698