[HBD] Tighten-up which adobe.com/go links are intercepted as Flash URLs

chrome/browser/plugins/flash_download_interception_unittest.cc

Index: chrome/browser/plugins/flash_download_interception_unittest.cc
diff --git a/chrome/browser/plugins/flash_download_interception_unittest.cc b/chrome/browser/plugins/flash_download_interception_unittest.cc
index 9e861fcf56590de8588e65b5775f4562bfec100e..644d9cfaf7134ab3a9e79ec047e34d6b653a9edd 100644
--- a/chrome/browser/plugins/flash_download_interception_unittest.cc
+++ b/chrome/browser/plugins/flash_download_interception_unittest.cc
@@ -49,6 +49,7 @@ TEST_F(FlashDownloadInterceptionTest, DownloadUrlVariations) {
       "http://get.adobe.com/flashplayer",
       "http://macromedia.com/go/getflashplayer",
       "http://adobe.com/go/getflashplayer",
+      "http://adobe.com/go/CA-H-GET-FLASH",

[mihai.balan, 2017/04/11 06:18:12]

The code as it is now would still intercept
https://www.macromedia.com/go/gnavtray_myadobe_myinformation_en_us?ua=chrome-...
-- which isn't exactly the intention, as far as I can tell

[tommycli, 2017/04/11 17:40:04]

Done. I added an explicit check to avoid intercepting this.

       "http://adobe.com/go/gntray_dl_getflashplayer_jp",

[raymes, 2017/04/10 23:54:13]

I feel like we could add a few more URLs here to match cases that were made more
specific in this CL, e.g. the h-m-a case?

[tommycli, 2017/04/11 17:40:05]

Done. I added the h-m-a case, but we specifically want to be cautious and not
leak all of Adobe's URLs (according to laforge). I internally test with the
whole list.

   };
 
@@ -58,14 +59,15 @@ TEST_F(FlashDownloadInterceptionTest, DownloadUrlVariations) {
   }
 
   const char* flash_no_intercept_urls[] = {
-      "https://www.example.com",

[tommycli, 2017/04/10 23:05:53]

git cl format wanted to collaspe these lines...

-      "http://example.com/get.adobe.com/flashplayer",
+      "https://www.example.com", "http://example.com/get.adobe.com/flashplayer",
       "http://ww.macromedia.com/go/getflashplayer",
       "http://wwwxmacromedia.com/go/getflashplayer",
       "http://www.adobe.com/software/flash/about/",
       "http://www.adobe.com/products/flashplayer.html",
       "http://www.adobe.com/products/flashruntimes.html",
       "http://www.adobe.com/go/flash",
+      // Don't intercept URLs containing just "fp" without a matching prefix.
+      "http://www.adobe.com/go/non-matching-prefix-fp",
   };
 
   for (auto* url : flash_no_intercept_urls) {