Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1438)

Unified Diff: chrome/browser/plugins/flash_download_interception.cc

Issue 2811903002: [HBD] Tighten-up which adobe.com/go links are intercepted as Flash URLs (Closed)
Patch Set: fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/plugins/flash_download_interception.cc
diff --git a/chrome/browser/plugins/flash_download_interception.cc b/chrome/browser/plugins/flash_download_interception.cc
index 24c23ec37b90441a540397d3f79127e0bd60c064..a3af3629455b365bc4d679ea6a001dfea1a7e795 100644
--- a/chrome/browser/plugins/flash_download_interception.cc
+++ b/chrome/browser/plugins/flash_download_interception.cc
@@ -32,9 +32,11 @@ namespace {
// Regexes matching
const char kGetFlashURLCanonicalRegex[] = "(?i)get\\.adobe\\.com/.*flash.*";
const char kGetFlashURLSecondaryRegex[] =
- "(?i)(www\\.)?(adobe|macromedia)\\.com/go.*"
- "(get[-_]?flash|fl(ash)?.?pl(ayer)?|flash_completion|flashpm|flashdownload|"
- "fp|h-m-a-?2|chrome|download_player|gnav_fl|pdcredirect).*";
+ "(?i)(www\\.)?(adobe|macromedia)\\.com/go/"
+ "((?i).*get[-_]?flash|getfp10android|.*fl(ash)player|.*flashpl|"
raymes 2017/04/10 23:54:13 is the (?i) needed here?
tommycli 2017/04/11 17:40:04 Yes, because both 'flashdownload' and 'FlashDownlo
+ ".*flash_player|flash_completion|flashpm|.*flashdownload|d65_flplayer|"
+ "fp_jp|runtimes_fp|[a-z_-]{3,6}h-m-a-?2|chrome|download_player|"
+ "gnav_fl|pdcredirect).*";
void DoNothing(ContentSetting result) {}

Powered by Google App Engine
This is Rietveld 408576698