[HBD] Tighten-up which adobe.com/go links are intercepted as Flash URLs

chrome/browser/plugins/flash_download_interception_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/plugins/flash_download_interception.h"
 
 #include "base/test/scoped_feature_list.h"
 #include "chrome/browser/content_settings/host_content_settings_map_factory.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
@@ skipping 31 matching lines @@
   base::test::ScopedFeatureList feature_list;
   feature_list.InitAndEnableFeature(features::kPreferHtmlOverPlugins);
 
   const char* flash_intercept_urls[] = {
       "https://get.adobe.com/flashplayer/",
       "http://get.adobe.com/flash",
       "http://get.adobe.com/fr/flashplayer/",
       "http://get.adobe.com/flashplayer",
       "http://macromedia.com/go/getflashplayer",
       "http://adobe.com/go/getflashplayer",
+      "http://adobe.com/go/CA-H-GET-FLASH",

[mihai.balan, 2017/04/11 06:18:12]

The code as it is now would still intercept
https://www.macromedia.com/go/gnavtray_myadobe_myinformation_en_us?ua=chrome-...
-- which isn't exactly the intention, as far as I can tell

[tommycli, 2017/04/11 17:40:04]

Done. I added an explicit check to avoid intercepting this.

       "http://adobe.com/go/gntray_dl_getflashplayer_jp",

[raymes, 2017/04/10 23:54:13]

I feel like we could add a few more URLs here to match cases that were made more
specific in this CL, e.g. the h-m-a case?

[tommycli, 2017/04/11 17:40:05]

Done. I added the h-m-a case, but we specifically want to be cautious and not
leak all of Adobe's URLs (according to laforge). I internally test with the
whole list.

   };
 
   for (auto* url : flash_intercept_urls) {
     EXPECT_TRUE(ShouldStopFlashDownloadAction(url))
         << "Should have intercepted: " << url;
   }
 
   const char* flash_no_intercept_urls[] = {
-      "https://www.example.com",

[tommycli, 2017/04/10 23:05:53]

git cl format wanted to collaspe these lines...

-      "http://example.com/get.adobe.com/flashplayer",
+      "https://www.example.com", "http://example.com/get.adobe.com/flashplayer",
       "http://ww.macromedia.com/go/getflashplayer",
       "http://wwwxmacromedia.com/go/getflashplayer",
       "http://www.adobe.com/software/flash/about/",
       "http://www.adobe.com/products/flashplayer.html",
       "http://www.adobe.com/products/flashruntimes.html",
       "http://www.adobe.com/go/flash",
+      // Don't intercept URLs containing just "fp" without a matching prefix.
+      "http://www.adobe.com/go/non-matching-prefix-fp",
   };
 
   for (auto* url : flash_no_intercept_urls) {
     EXPECT_FALSE(ShouldStopFlashDownloadAction(url))
         << "Should not have intercepted: " << url;
   }
 
   // Don't intercept navigations occurring on the flash download page.
   EXPECT_FALSE(FlashDownloadInterception::ShouldStopFlashDownloadAction(
       host_content_settings_map(), GURL("https://get.adobe.com/flashplayer/"),
@@ skipping 39 matching lines @@
   // Intercept on both explicit DETECT and BLOCK.
   map->SetDefaultContentSetting(CONTENT_SETTINGS_TYPE_PLUGINS,
                                 CONTENT_SETTING_BLOCK);
   EXPECT_TRUE(
       ShouldStopFlashDownloadAction("https://get.adobe.com/flashplayer/"));
   map->SetDefaultContentSetting(CONTENT_SETTINGS_TYPE_PLUGINS,
                                 CONTENT_SETTING_DETECT_IMPORTANT_CONTENT);
   EXPECT_TRUE(
       ShouldStopFlashDownloadAction("https://get.adobe.com/flashplayer/"));
 }