Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2811833002: Move ScriptState::GetExecutionContext (Part 2) (Closed)

Created:
3 years, 8 months ago by adithyas
Modified:
3 years, 8 months ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ScriptState::GetExecutionContext (Part 2) This CL replaces uses of ScriptState::GetExecutionContext with ExecutionContext::From in the bindings generator code. BUG=682322 Review-Url: https://codereview.chromium.org/2811833002 Cr-Commit-Position: refs/heads/master@{#463394} Committed: https://chromium.googlesource.com/chromium/src/+/f56ccf3f087fe868c7188ce23a162886744211f7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add 2 sp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -25 lines) Patch
M third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp View 1 15 chunks +23 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
adithyas
3 years, 8 months ago (2017-04-10 18:31:31 UTC) #2
jbroman
lgtm https://codereview.chromium.org/2811833002/diff/1/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl File third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl (right): https://codereview.chromium.org/2811833002/diff/1/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl#newcode28 third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl:28: ExecutionContext::From(m_scriptState.Get()); nit: I think 4sp indent is correct ...
3 years, 8 months ago (2017-04-10 18:36:52 UTC) #3
adithyas
https://codereview.chromium.org/2811833002/diff/1/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl File third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl (right): https://codereview.chromium.org/2811833002/diff/1/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl#newcode28 third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl:28: ExecutionContext::From(m_scriptState.Get()); On 2017/04/10 at 18:36:52, jbroman wrote: > nit: ...
3 years, 8 months ago (2017-04-10 19:37:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811833002/20001
3 years, 8 months ago (2017-04-10 19:38:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/f56ccf3f087fe868c7188ce23a162886744211f7
3 years, 8 months ago (2017-04-10 21:17:13 UTC) #10
haraken
3 years, 8 months ago (2017-04-11 00:12:12 UTC) #11
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698