Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 2811803003: Revert of Only create sticky position constraints for constrained sticky position. (Closed)

Created:
3 years, 8 months ago by Xi Han
Modified:
3 years, 8 months ago
Reviewers:
flackr, chrishtr
CC:
blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Only create sticky position constraints for constrained sticky position. (patchset #4 id:60001 of https://codereview.chromium.org/2769353002/ ) Reason for revert: It causes telemetry_perf_unittests failing on chromium.android/Android N5X Swarm Builder. crbug.com/710142. Original issue's description: > Only create sticky position constraints for constrained sticky position. > > If sticky position is unconstrained we don't need to create constraints for it, > or add it to viewport constrained objects (causing scroll on main), or repaint > on scroll. > > BUG=704817 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Review-Url: https://codereview.chromium.org/2769353002 > Cr-Commit-Position: refs/heads/master@{#463316} > Committed: https://chromium.googlesource.com/chromium/src/+/06e9b5a6a5649e4d842f40ad667554c58dc26c29 TBR=chrishtr@chromium.org,flackr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=704817 Review-Url: https://codereview.chromium.org/2811803003 Cr-Commit-Position: refs/heads/master@{#463402} Committed: https://chromium.googlesource.com/chromium/src/+/e0f87e573b0b8cba4b2d739a8c5a86c0f448d513

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
Xi Han
Created Revert of Only create sticky position constraints for constrained sticky position.
3 years, 8 months ago (2017-04-10 21:30:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2811803003/1
3 years, 8 months ago (2017-04-10 21:31:23 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 21:35:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e0f87e573b0b8cba4b2d739a8c5a...

Powered by Google App Engine
This is Rietveld 408576698