MD Settings: Restore focus after exiting various subpages.

MD Settings: Restore focus after exiting various subpages.

Addressing subpages residing in
 - a11y_page
 - appearance_page
 - languages_page
 - people_page
 - printing_page (except CUPS printer sub-sub page).

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2811693004
Cr-Commit-Position: refs/heads/master@{#463527}
Committed: https://chromium.googlesource.com/chromium/src/+/a4375e001388a81979b761bfb4fa60b572d0ecc8

[dpapad, 2017-04-10 20:45:33]

Description was changed from

==========
MD Settings: Restore focus after exiting People subpages.

BUG=709586
==========

to

==========
MD Settings: Restore focus after exiting People subpages.

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-11 00:06:26]

Description was changed from

==========
MD Settings: Restore focus after exiting People subpages.

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Restore focus after exiting People subpages.

 - people_page
 - appearance_page
 - languages_page

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-11 00:06:37]

Description was changed from

==========
MD Settings: Restore focus after exiting People subpages.

 - people_page
 - appearance_page
 - languages_page

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Restore focus after exiting People subpages.

Addressing subpages residing in
 - people_page
 - appearance_page
 - languages_page

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-11 01:02:37]

Description was changed from

==========
MD Settings: Restore focus after exiting People subpages.

Addressing subpages residing in
 - people_page
 - appearance_page
 - languages_page

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Restore focus after exiting People subpages.

Addressing subpages residing in
 - a11y_page
 - appearance_page
 - languages_page
 - people_page

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-11 01:02:50]

Description was changed from

==========
MD Settings: Restore focus after exiting People subpages.

Addressing subpages residing in
 - a11y_page
 - appearance_page
 - languages_page
 - people_page

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Restore focus after exiting various subpages.

Addressing subpages residing in
 - a11y_page
 - appearance_page
 - languages_page
 - people_page

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-11 01:30:12]

Description was changed from

==========
MD Settings: Restore focus after exiting various subpages.

Addressing subpages residing in
 - a11y_page
 - appearance_page
 - languages_page
 - people_page

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Restore focus after exiting various subpages.

Addressing subpages residing in
 - a11y_page
 - appearance_page
 - languages_page
 - people_page
 - printing_page (except CUPS printer sub-sub page).

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-04-11 01:42:15]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 01:42:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-04-11 01:43:45]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2017-04-11 01:43:45]

These are all subpage to top-level page navigations (the easy cases). I have not
dealt with subpage to subpage navigations yet.

[Dan Beam, 2017-04-11 02:23:56]

lgtm

https://codereview.chromium.org/2811693004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/a11y_page/a11y_page.js (right):

https://codereview.chromium.org/2811693004/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/a11y_page/a11y_page.js:38: this.focusConfig_ =
new Map();
is there a reason we can't just set

this.$.pages.focusConfig = new Map();

here instead of using binding?  OR

focusConfig_: {
  type: Object,
  value: function() {
    var focusConfig = new Map();
    focusConfig.set(..., ...);
    return focusConfig;
  },
},

to fully use properties?

https://codereview.chromium.org/2811693004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/languages_page/languages_page.js (right):

https://codereview.chromium.org/2811693004/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/languages_page/languages_page.js:69: // <if
expr="not is_macosx">
fwiw: these will eventually get reformatted with `git cl format --js` to be
indented with the code

[commit-bot: I haz the power, 2017-04-11 02:38:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 02:38:36]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dpapad, 2017-04-11 03:01:01]

https://codereview.chromium.org/2811693004/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/a11y_page/a11y_page.js (right):

https://codereview.chromium.org/2811693004/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/a11y_page/a11y_page.js:38: this.focusConfig_ =
new Map();
On 2017/04/11 at 02:23:56, Dan Beam wrote:
> is there a reason we can't just set
> 
> this.$.pages.focusConfig = new Map();
> 
> here instead of using binding?  OR
> 
> focusConfig_: {
>   type: Object,
>   value: function() {
>     var focusConfig = new Map();
>     focusConfig.set(..., ...);
>     return focusConfig;
>   },
> },
> 
> to fully use properties?

Done. It was a remainder from my original approach which was calling
querySelector() in ready(), not needed anymore.

https://codereview.chromium.org/2811693004/diff/80001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/cr_settings_browsertest.js (left):

https://codereview.chromium.org/2811693004/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/settings/cr_settings_browsertest.js:1181:
settings.navigateTo(settings.Route.SYNC, params);
This test was visiting the /syncSetup subpage, even though that subpage is only
visible when the user is logged in (the test is not simulating a logged in
user). Changed it to a different pair of Routes, since the exact route does not
really matter for the purposes of this test.

[dpapad, 2017-04-11 03:04:44]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 03:05:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2017-04-11 03:06:15]

still lgtm

[dpapad, 2017-04-11 03:08:24]

The CQ bit was unchecked by dpapad@chromium.org

[dpapad, 2017-04-11 03:08:31]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-04-11 03:09:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 04:07:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491880111298730,
"parent_rev": "6c884e6488c882cf15b6332541f1437050265aed", "commit_rev":
"a4375e001388a81979b761bfb4fa60b572d0ecc8"}

[commit-bot: I haz the power, 2017-04-11 04:09:22]

Description was changed from

==========
MD Settings: Restore focus after exiting various subpages.

Addressing subpages residing in
 - a11y_page
 - appearance_page
 - languages_page
 - people_page
 - printing_page (except CUPS printer sub-sub page).

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Restore focus after exiting various subpages.

Addressing subpages residing in
 - a11y_page
 - appearance_page
 - languages_page
 - people_page
 - printing_page (except CUPS printer sub-sub page).

BUG=709586
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2811693004
Cr-Commit-Position: refs/heads/master@{#463527}
Committed:
https://chromium.googlesource.com/chromium/src/+/a4375e001388a81979b761bfb4fa...
==========

[commit-bot: I haz the power, 2017-04-11 04:09:23]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/a4375e001388a81979b761bfb4fa...