Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4891)

Unified Diff: chrome/test/data/webui/settings/cr_settings_browsertest.js

Issue 2811693004: MD Settings: Restore focus after exiting various subpages. (Closed)
Patch Set: Address comments, fix test. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/printing_page/printing_page.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/cr_settings_browsertest.js
diff --git a/chrome/test/data/webui/settings/cr_settings_browsertest.js b/chrome/test/data/webui/settings/cr_settings_browsertest.js
index 5b26a8b1e35180b1c8ccfddd717bbd310e78448f..092b6b99ec8fc5c03d30e25fcb84bd8aa79e0aa8 100644
--- a/chrome/test/data/webui/settings/cr_settings_browsertest.js
+++ b/chrome/test/data/webui/settings/cr_settings_browsertest.js
@@ -1162,7 +1162,7 @@ CrSettingsRouteDynamicParametersTest.prototype = {
__proto__: CrSettingsBrowserTest.prototype,
/** @override */
- browsePreload: 'chrome://md-settings/people?guid=a%2Fb&foo=42',
+ browsePreload: 'chrome://md-settings/search?guid=a%2Fb&foo=42',
/** @override */
runAccessibilityChecks: false,
@@ -1171,22 +1171,22 @@ CrSettingsRouteDynamicParametersTest.prototype = {
TEST_F('CrSettingsRouteDynamicParametersTest', 'All', function() {
suite('DynamicParameters', function() {
test('get parameters from URL and navigation', function(done) {
- assertEquals(settings.Route.PEOPLE, settings.getCurrentRoute());
+ assertEquals(settings.Route.SEARCH, settings.getCurrentRoute());
assertEquals('a/b', settings.getQueryParameters().get('guid'));
assertEquals('42', settings.getQueryParameters().get('foo'));
var params = new URLSearchParams();
params.set('bar', 'b=z');
params.set('biz', '3');
- settings.navigateTo(settings.Route.SYNC, params);
dpapad 2017/04/11 03:01:01 This test was visiting the /syncSetup subpage, eve
- assertEquals(settings.Route.SYNC, settings.getCurrentRoute());
+ settings.navigateTo(settings.Route.SEARCH_ENGINES, params);
+ assertEquals(settings.Route.SEARCH_ENGINES, settings.getCurrentRoute());
assertEquals('b=z', settings.getQueryParameters().get('bar'));
assertEquals('3', settings.getQueryParameters().get('biz'));
assertEquals('?bar=b%3Dz&biz=3', window.location.search);
window.addEventListener('popstate', function(event) {
- assertEquals('/people', settings.getCurrentRoute().path);
- assertEquals(settings.Route.PEOPLE, settings.getCurrentRoute());
+ assertEquals('/search', settings.getCurrentRoute().path);
+ assertEquals(settings.Route.SEARCH, settings.getCurrentRoute());
assertEquals('a/b', settings.getQueryParameters().get('guid'));
assertEquals('42', settings.getQueryParameters().get('foo'));
done();
« no previous file with comments | « chrome/browser/resources/settings/printing_page/printing_page.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698