Fetch API: Add Request#cache attribute

Fetch API: Add Request#cache attribute

Behind the run time flag FetchRequestCache, a new attribute |cache| 
is added into fetch request. Cache can be set to "default", "no-store", 
"reload", "no-cache", "force-cache" or "only-if-cached". Please refer 
to https://fetch.spec.whatwg.org/#requestsNote for exact definition. 
Note that the implementation of cache options are not completed yet. 

TEST=request-init-003.sub.html

BUG=453190
Review-Url: https://codereview.chromium.org/2811623002
Cr-Commit-Position: refs/heads/master@{#464032}
Committed: https://chromium.googlesource.com/chromium/src/+/8a82f1f36590e504b12f486df6351e78ca223097

[yiyix, 2017-04-10 06:55:26]

Description was changed from

==========
add attribute

not donw

BUG=
==========

to

==========
[WIP] Fetch API: Add cache attribute

not donw

BUG=
==========

[yiyix, 2017-04-10 06:55:37]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 06:55:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 08:28:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 08:28:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yiyix, 2017-04-10 09:47:55]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 09:48:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yiyix, 2017-04-10 10:08:39]

Patchset #1 (id:1) has been deleted

[yiyix, 2017-04-10 10:09:52]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 10:10:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 11:41:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 11:41:36]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yiyix, 2017-04-10 11:52:48]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 11:53:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 13:48:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 13:48:35]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[yiyix, 2017-04-11 02:10:26]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 02:11:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 02:15:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 02:15:04]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yiyix, 2017-04-11 02:18:13]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[yiyix, 2017-04-11 02:18:35]

Description was changed from

==========
[WIP] Fetch API: Add cache attribute

not donw

BUG=
==========

to

==========
[WIP] Fetch API: Add cache attribute



BUG=
==========

[commit-bot: I haz the power, 2017-04-11 02:19:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 02:22:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 02:22:41]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[yiyix, 2017-04-11 02:27:01]

Patchset #2 (id:40001) has been deleted

[yiyix, 2017-04-11 02:27:10]

Patchset #3 (id:80001) has been deleted

[yiyix, 2017-04-11 02:27:16]

Patchset #3 (id:100001) has been deleted

[yiyix, 2017-04-11 02:27:45]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 02:28:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yiyix, 2017-04-11 02:39:27]

Description was changed from

==========
[WIP] Fetch API: Add cache attribute



BUG=
==========

to

==========
[WIP] Fetch API: Add cache attribute

Behind the run time flag FetchRequestCache, a new attribute |cache| is added
into fetch request.


BUG=453190
==========

[yiyix, 2017-04-11 03:34:41]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[yiyix, 2017-04-11 03:34:46]

Patchset #3 (id:120001) has been deleted

[commit-bot: I haz the power, 2017-04-11 03:34:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yiyix, 2017-04-11 04:31:26]

Description was changed from

==========
[WIP] Fetch API: Add cache attribute

Behind the run time flag FetchRequestCache, a new attribute |cache| is added
into fetch request.


BUG=453190
==========

to

==========
[WIP] Fetch API: Add cache attribute

Behind the run time flag FetchRequestCache, a new attribute |cache| 
is added into fetch request. Cache can be set to "default", "no-store", 
"reload", "no-cache", "force-cache" or "only-if-cached". Please refer 
to https://fetch.spec.whatwg.org/#requestsNote for exact definition. 
Note that the implementation of cache options are not completed yet. 

BUG=453190
==========

[yiyix, 2017-04-11 05:04:23]

yiyix@chromium.org changed reviewers:
+ falken@chromium.org

[yiyix, 2017-04-11 05:04:24]

@falken, could you please take a look at this change? Thank you.

[yiyix, 2017-04-11 05:04:36]

Patchset #1 (id:20001) has been deleted

[yiyix, 2017-04-11 05:04:47]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-04-11 05:44:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 05:44:32]

Dry run: This issue passed the CQ dry run.

[falken, 2017-04-11 05:53:59]

The change looks good from my side.

I prefer changing the "Cache" name to "CacheMode" when possible, everywhere
except for the Request.{idl,cpp,h} files. It's easier to understand the code
that way, even though it's not 100% the same as the spec. The name "Cache" looks
like an actual cache, or the verb "to cache".

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/FetchRequestData.h (right):

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchRequestData.h:68: }
SetCache() and Cache() are quite generic names, but I guess it's ok if it's
obvious that FetchRequestData represents the Fetch API's Request interface.

I slightly prefer changing these to SetCacheMode() and and CacheMode() as it's
clearer to read, although it's not exactly the same as the Request interface's
|cache| attribute. However, I'm not an OWNER of this file, so you can wait for
yhirano's input.

Question for yhirano: Is it obvious that FetchRequestData represents the DOM
Request interface? Should this have a class-level comment?

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.cpp (right):

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.cpp:274: }
nit: insert an empty line here?

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp
(right):

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp:37:
WebURLRequest::FetchRequestCache request_cache_;
nit: I prefer calling this |cache_mode_|. I think it'll be easier to understand
the code.

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp:159:
void WebServiceWorkerRequest::SetRequestCache(
nit: I prefer SetCacheMode() and CacheMode() here.

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/WebURLRequest.h (right):

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/pub...
third_party/WebKit/public/platform/WebURLRequest.h:124: enum FetchRequestCache {
I'm feeling FetchRequestCacheMode is clearer. There's precendence here due to
FetchCredentialsMode.

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/pub...
File
third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h
(right):

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/pub...
third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h:75:
WebURLRequest::FetchRequestCache RequestCache() const;
SetCacheMode() and CacheMode()

[yiyix, 2017-04-11 06:05:21]

yiyix@chromium.org changed reviewers:
+ yhirano@chromium.org

[yhirano, 2017-04-11 06:26:52]

I generally prefer exposing an IDL property after adding a testable
implementation. Is it possible?

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/FetchRequestData.h (right):

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchRequestData.h:68: }
On 2017/04/11 05:53:59, falken wrote:
> SetCache() and Cache() are quite generic names, but I guess it's ok if it's
> obvious that FetchRequestData represents the Fetch API's Request interface.
> 
> I slightly prefer changing these to SetCacheMode() and and CacheMode() as it's
> clearer to read, although it's not exactly the same as the Request interface's
> |cache| attribute. However, I'm not an OWNER of this file, so you can wait for
> yhirano's input.
> 
> Question for yhirano: Is it obvious that FetchRequestData represents the DOM
> Request interface? Should this have a class-level comment?

[Set]CacheMode sounds better to me, too.

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/WebURLRequest.h (right):

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/pub...
third_party/WebKit/public/platform/WebURLRequest.h:124: enum FetchRequestCache {
On 2017/04/11 05:53:59, falken wrote:
> I'm feeling FetchRequestCacheMode is clearer. There's precendence here due to
> FetchCredentialsMode.

+1

[falken, 2017-04-11 06:40:45]

Just to be clear, the IDL change is gated by a flag.

There are WPT for this. This change fixes some failures. It looks like the only
failure is that FetchEvent.request.cache for a window.location.reload() should
be 'no-cache' instead of 'default'.

The plan was to incrementally get the tests passing while developing behind a
flag, and then adding more tests where there is missing coverage (and it looks
like there is a lot of missing coverage).

Would you advise we take a different approach?

[yiyix, 2017-04-11 07:14:28]

Description was changed from

==========
[WIP] Fetch API: Add cache attribute

Behind the run time flag FetchRequestCache, a new attribute |cache| 
is added into fetch request. Cache can be set to "default", "no-store", 
"reload", "no-cache", "force-cache" or "only-if-cached". Please refer 
to https://fetch.spec.whatwg.org/#requestsNote for exact definition. 
Note that the implementation of cache options are not completed yet. 

BUG=453190
==========

to

==========
Fetch API: Add cache attribute

Behind the run time flag FetchRequestCache, a new attribute |cache| 
is added into fetch request. Cache can be set to "default", "no-store", 
"reload", "no-cache", "force-cache" or "only-if-cached". Please refer 
to https://fetch.spec.whatwg.org/#requestsNote for exact definition. 
Note that the implementation of cache options are not completed yet. 

BUG=453190
==========

[yhirano, 2017-04-11 09:16:43]

Hmm, Ok...

Can you put a TODO somewhere in the source code?

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/RequestInit.cpp (right):

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/RequestInit.cpp:48: are_any_members_set
|= DictionaryHelper::Get(options, "cache", cache);
This should be behind the flag.

[yiyix, 2017-04-11 10:00:06]

@falken and @yhirano, could you please review this new patch?

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/FetchRequestData.h (right):

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchRequestData.h:68: }
On 2017/04/11 06:26:51, yhirano wrote:
> On 2017/04/11 05:53:59, falken wrote:
> > SetCache() and Cache() are quite generic names, but I guess it's ok if it's
> > obvious that FetchRequestData represents the Fetch API's Request interface.
> > 
> > I slightly prefer changing these to SetCacheMode() and and CacheMode() as
it's
> > clearer to read, although it's not exactly the same as the Request
interface's
> > |cache| attribute. However, I'm not an OWNER of this file, so you can wait
for
> > yhirano's input.
> > 
> > Question for yhirano: Is it obvious that FetchRequestData represents the DOM
> > Request interface? Should this have a class-level comment?
> 
> [Set]CacheMode sounds better to me, too.

Done.

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/Request.cpp (right):

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/Request.cpp:274: }
On 2017/04/11 05:53:59, falken wrote:
> nit: insert an empty line here?

Done.

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/RequestInit.cpp (right):

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/RequestInit.cpp:48: are_any_members_set
|= DictionaryHelper::Get(options, "cache", cache);
On 2017/04/11 09:16:43, yhirano wrote:
> This should be behind the flag.

You are right, the variable |cache| will still be set in this approach. 
Done.

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp
(right):

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp:37:
WebURLRequest::FetchRequestCache request_cache_;
On 2017/04/11 05:53:59, falken wrote:
> nit: I prefer calling this |cache_mode_|. I think it'll be easier to
understand
> the code.

Done.

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/exported/WebServiceWorkerRequest.cpp:159:
void WebServiceWorkerRequest::SetRequestCache(
On 2017/04/11 05:53:59, falken wrote:
> nit: I prefer SetCacheMode() and CacheMode() here.

Done.

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/pub...
File third_party/WebKit/public/platform/WebURLRequest.h (right):

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/pub...
third_party/WebKit/public/platform/WebURLRequest.h:124: enum FetchRequestCache {
On 2017/04/11 06:26:51, yhirano wrote:
> On 2017/04/11 05:53:59, falken wrote:
> > I'm feeling FetchRequestCacheMode is clearer. There's precendence here due
to
> > FetchCredentialsMode.
> 
> +1

Done.

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/pub...
File
third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h
(right):

https://codereview.chromium.org/2811623002/diff/140001/third_party/WebKit/pub...
third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRequest.h:75:
WebURLRequest::FetchRequestCache RequestCache() const;
On 2017/04/11 05:53:59, falken wrote:
> SetCacheMode() and CacheMode()

Done.

[yhirano, 2017-04-11 10:21:15]

The CQ bit was checked by yhirano@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 10:21:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 13:16:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 13:16:06]

Dry run: This issue passed the CQ dry run.

[yhirano, 2017-04-11 14:08:36]

LGTM. All code suggestions are optional.

As said in #47, please put TODO that you need to transfer the mode to the
network layer and service worker.

https://codereview.chromium.org/2811623002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/FetchRequestData.h (right):

https://codereview.chromium.org/2811623002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchRequestData.h:69: void
SetCacheMode(WebURLRequest::FetchRequestCacheMode cache) {
cache_mode?

https://codereview.chromium.org/2811623002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchRequestData.h:127:
WebURLRequest::FetchRequestCacheMode cache_;
cache_mode_?

[falken, 2017-04-12 01:48:23]

lgtm

nit in CL description: "Add Request#cache attribute" to be more clear

https://codereview.chromium.org/2811623002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/FetchRequestData.h (right):

https://codereview.chromium.org/2811623002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchRequestData.h:127:
WebURLRequest::FetchRequestCacheMode cache_;
On 2017/04/11 14:08:36, yhirano wrote:
> cache_mode_?

+1

[yiyix, 2017-04-12 04:00:26]

The CQ bit was checked by yiyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 04:00:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yiyix, 2017-04-12 04:02:35]

yiyix@chromium.org changed reviewers:
+ tkent@chromium.org

[yiyix, 2017-04-12 04:02:36]

@falken and @yhirano: Thank you for reviewing.
@tkent: could you please review changes in platform? Thank you

https://codereview.chromium.org/2811623002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/fetch/FetchRequestData.h (right):

https://codereview.chromium.org/2811623002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchRequestData.h:69: void
SetCacheMode(WebURLRequest::FetchRequestCacheMode cache) {
On 2017/04/11 14:08:36, yhirano wrote:
> cache_mode?

Done.

https://codereview.chromium.org/2811623002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/fetch/FetchRequestData.h:127:
WebURLRequest::FetchRequestCacheMode cache_;
On 2017/04/11 14:08:36, yhirano wrote:
> cache_mode_?

Done.

[yiyix, 2017-04-12 06:34:12]

Description was changed from

==========
Fetch API: Add cache attribute

Behind the run time flag FetchRequestCache, a new attribute |cache| 
is added into fetch request. Cache can be set to "default", "no-store", 
"reload", "no-cache", "force-cache" or "only-if-cached". Please refer 
to https://fetch.spec.whatwg.org/#requestsNote for exact definition. 
Note that the implementation of cache options are not completed yet. 

BUG=453190
==========

to

==========
Fetch API: Add Request#cache attribut

Behind the run time flag FetchRequestCache, a new attribute |cache| 
is added into fetch request. Cache can be set to "default", "no-store", 
"reload", "no-cache", "force-cache" or "only-if-cached". Please refer 
to https://fetch.spec.whatwg.org/#requestsNote for exact definition. 
Note that the implementation of cache options are not completed yet. 

TEST=request-init-003.sub.html

BUG=453190
==========

[commit-bot: I haz the power, 2017-04-12 06:34:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 06:34:20]

Dry run: This issue passed the CQ dry run.

[yiyix, 2017-04-12 06:34:35]

Description was changed from

==========
Fetch API: Add Request#cache attribut

Behind the run time flag FetchRequestCache, a new attribute |cache| 
is added into fetch request. Cache can be set to "default", "no-store", 
"reload", "no-cache", "force-cache" or "only-if-cached". Please refer 
to https://fetch.spec.whatwg.org/#requestsNote for exact definition. 
Note that the implementation of cache options are not completed yet. 

TEST=request-init-003.sub.html

BUG=453190
==========

to

==========
Fetch API: Add Request#cache attribute

Behind the run time flag FetchRequestCache, a new attribute |cache| 
is added into fetch request. Cache can be set to "default", "no-store", 
"reload", "no-cache", "force-cache" or "only-if-cached". Please refer 
to https://fetch.spec.whatwg.org/#requestsNote for exact definition. 
Note that the implementation of cache options are not completed yet. 

TEST=request-init-003.sub.html

BUG=453190
==========

[tkent, 2017-04-12 13:30:34]

lgtm

[yiyix, 2017-04-12 14:53:42]

The CQ bit was checked by yiyix@chromium.org

[yiyix, 2017-04-12 14:53:42]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org,
yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2811623002/#ps180001
(title: "address comments")

[commit-bot: I haz the power, 2017-04-12 14:54:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 15:00:02]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1492008822288190,
"parent_rev": "db6866c4fe346a958cb93c0495266cd59ac29937", "commit_rev":
"cd3c1cc414f5a006d7907f0b756494e6b62ebd9b"}

[commit-bot: I haz the power, 2017-04-12 15:14:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 15:14:13]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[yiyix, 2017-04-12 15:20:25]

The CQ bit was checked by yiyix@chromium.org

[commit-bot: I haz the power, 2017-04-12 15:21:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 15:28:18]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1492010425189710,
"parent_rev": "80e3eb904ef28e2491b831099597fc05347845ae", "commit_rev":
"8a82f1f36590e504b12f486df6351e78ca223097"}

[commit-bot: I haz the power, 2017-04-12 15:29:17]

Description was changed from

==========
Fetch API: Add Request#cache attribute

Behind the run time flag FetchRequestCache, a new attribute |cache| 
is added into fetch request. Cache can be set to "default", "no-store", 
"reload", "no-cache", "force-cache" or "only-if-cached". Please refer 
to https://fetch.spec.whatwg.org/#requestsNote for exact definition. 
Note that the implementation of cache options are not completed yet. 

TEST=request-init-003.sub.html

BUG=453190
==========

to

==========
Fetch API: Add Request#cache attribute

Behind the run time flag FetchRequestCache, a new attribute |cache| 
is added into fetch request. Cache can be set to "default", "no-store", 
"reload", "no-cache", "force-cache" or "only-if-cached". Please refer 
to https://fetch.spec.whatwg.org/#requestsNote for exact definition. 
Note that the implementation of cache options are not completed yet. 

TEST=request-init-003.sub.html

BUG=453190

Review-Url: https://codereview.chromium.org/2811623002
Cr-Commit-Position: refs/heads/master@{#464032}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a82f1f36590e504b12f486df635...
==========

[commit-bot: I haz the power, 2017-04-12 15:29:18]

Committed patchset #3 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/8a82f1f36590e504b12f486df635...