Fetch API: Add Request#cache attribute

third_party/WebKit/Source/modules/fetch/FetchRequestData.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef FetchRequestData_h
 #define FetchRequestData_h
 
 #include "platform/heap/Handle.h"
 #include "platform/network/EncodedFormData.h"
 #include "platform/weborigin/KURL.h"
@@ skipping 47 matching lines @@
   void SetReferrer(const Referrer& r) { referrer_ = r; }
   const AtomicString& ReferrerString() const { return referrer_.referrer; }
   void SetReferrerString(const AtomicString& s) { referrer_.referrer = s; }
   ReferrerPolicy GetReferrerPolicy() const { return referrer_.referrer_policy; }
   void SetReferrerPolicy(ReferrerPolicy p) { referrer_.referrer_policy = p; }
   void SetMode(WebURLRequest::FetchRequestMode mode) { mode_ = mode; }
   WebURLRequest::FetchRequestMode Mode() const { return mode_; }
   void SetCredentials(WebURLRequest::FetchCredentialsMode);
   WebURLRequest::FetchCredentialsMode Credentials() const {
     return credentials_;
   }

[falken, 2017/04/11 05:53:59]

SetCache() and Cache() are quite generic names, but I guess it's ok if it's
obvious that FetchRequestData represents the Fetch API's Request interface.

I slightly prefer changing these to SetCacheMode() and and CacheMode() as it's
clearer to read, although it's not exactly the same as the Request interface's
|cache| attribute. However, I'm not an OWNER of this file, so you can wait for
yhirano's input.

Question for yhirano: Is it obvious that FetchRequestData represents the DOM
Request interface? Should this have a class-level comment?

[yhirano, 2017/04/11 06:26:51]

[Set]CacheMode sounds better to me, too.

[yiyix, 2017/04/11 10:00:06]

Done.

+  void SetCache(WebURLRequest::FetchRequestCache cache) { cache_ = cache; }
+  WebURLRequest::FetchRequestCache Cache() const { return cache_; }
   void SetRedirect(WebURLRequest::FetchRedirectMode redirect) {
     redirect_ = redirect;
   }
   WebURLRequest::FetchRedirectMode Redirect() const { return redirect_; }
   void SetResponseTainting(Tainting tainting) { response_tainting_ = tainting; }
   Tainting ResponseTainting() const { return response_tainting_; }
   FetchHeaderList* HeaderList() const { return header_list_.Get(); }
   void SetHeaderList(FetchHeaderList* header_list) {
     header_list_ = header_list;
   }
@@ skipping 34 matching lines @@
   // FIXME: Support m_forceOriginHeaderFlag;
   bool same_origin_data_url_flag_;
   // |m_referrer| consists of referrer string and referrer policy.
   // We use |noReferrerString()| and |clientReferrerString()| as
   // "no-referrer" and "client" strings in the spec.
   Referrer referrer_;
   // FIXME: Support m_authenticationFlag;
   // FIXME: Support m_synchronousFlag;
   WebURLRequest::FetchRequestMode mode_;
   WebURLRequest::FetchCredentialsMode credentials_;
+  WebURLRequest::FetchRequestCache cache_;
   WebURLRequest::FetchRedirectMode redirect_;
   // FIXME: Support m_useURLCredentialsFlag;
   // FIXME: Support m_redirectCount;
   Tainting response_tainting_;
   Member<BodyStreamBuffer> buffer_;
   String mime_type_;
   String integrity_;
   RefPtr<EncodedFormData> attached_credential_;
 };
 
 }  // namespace blink
 
 #endif  // FetchRequestData_h