[ios] Allow having multiple session windows in a session.

[ios] Allow having multiple session windows in a session.

With the new architecture, there can be multiple WebStateList per
ChromeBrowserState (due to BrowserList owning multiple Browsers).

Introduce SessionIOS that store the information about a session
(e.g. a BrowserList) with a list of SessionWindowIOS objects and
change SessionServiceIOS to use SessionIOS in its API.

Add support for loading legacy saved session with a single root
object of type SessionWindowIOS by creating a SessionIOS on the
fly.

BUG=710848
Review-Url: https://codereview.chromium.org/2811593004
Cr-Commit-Position: refs/heads/master@{#465623}
Committed: https://chromium.googlesource.com/chromium/src/+/dcc6c6ec0d3999a98c28a0124ef6ca232ef907a5

[sdefresne, 2017-04-10 15:00:21]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 15:00:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-04-10 15:00:52]

sdefresne@chromium.org changed reviewers:
+ marq@chromium.org

[sdefresne, 2017-04-10 15:00:53]

Please take a look.

[commit-bot: I haz the power, 2017-04-10 16:17:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:17:46]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-04-11 08:26:10]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 08:26:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 09:38:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 09:38:17]

Dry run: This issue passed the CQ dry run.

[marq (ping after 24h), 2017-04-11 10:47:55]

lgtm

[sdefresne, 2017-04-12 11:16:07]

Description was changed from

==========
[ios] Allow having multiple saved session in the same directory.

With the new architecture, there can be multiple WebStateList per
ChromeBrowserState (due to BrowserList owning multiple Browsers).

BUG=None
==========

to

==========
[ios] Allow having multiple saved session in the same directory.

With the new architecture, there can be multiple WebStateList per
ChromeBrowserState (due to BrowserList owning multiple Browsers).

Introduce SessionIOS that store the information about a session
(e.g. a BrowserList) with a list of SessionWindowIOS objects and
change SessionServiceIOS to use SessionIOS in its API.

Add support for loading legacy saved session with a single root
object of type SessionWindowIOS by creating a SessionIOS on the
fly.

BUG=None
==========

[sdefresne, 2017-04-12 11:20:55]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 11:21:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-04-12 11:24:34]

I've changed the CL to introduce SessionIOS owning a collection of
SessionWindowIOS. Could you take another look?

The original plan was to have a session_%d.plist per Browser, but I found that
it was cumbersome, as it required that I keep files in sync with the Browser
when they were added/removed, and that I enumerate the directory to find all the
session*.plist files.

Using a single session.plist file with a list of SessionWindowIOS instead of a
single object is simpler. I introduced the SessionIOS class so that we do not
have to refactor everything again if we decide to store some additional state
(for example position of each browsers, or which browser is currently active).

[commit-bot: I haz the power, 2017-04-12 12:23:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 12:23:25]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-04-12 13:57:11]

Description was changed from

==========
[ios] Allow having multiple saved session in the same directory.

With the new architecture, there can be multiple WebStateList per
ChromeBrowserState (due to BrowserList owning multiple Browsers).

Introduce SessionIOS that store the information about a session
(e.g. a BrowserList) with a list of SessionWindowIOS objects and
change SessionServiceIOS to use SessionIOS in its API.

Add support for loading legacy saved session with a single root
object of type SessionWindowIOS by creating a SessionIOS on the
fly.

BUG=None
==========

to

==========
[ios] Allow having multiple session windows in a session.

With the new architecture, there can be multiple WebStateList per
ChromeBrowserState (due to BrowserList owning multiple Browsers).

Introduce SessionIOS that store the information about a session
(e.g. a BrowserList) with a list of SessionWindowIOS objects and
change SessionServiceIOS to use SessionIOS in its API.

Add support for loading legacy saved session with a single root
object of type SessionWindowIOS by creating a SessionIOS on the
fly.

BUG=710848
==========

[sdefresne, 2017-04-18 14:07:42]

marq: ping

[marq (ping after 24h), 2017-04-18 15:16:55]

https://codereview.chromium.org/2811593004/diff/60001/ios/chrome/browser/sess...
File ios/chrome/browser/sessions/session_ios.h (right):

https://codereview.chromium.org/2811593004/diff/60001/ios/chrome/browser/sess...
ios/chrome/browser/sessions/session_ios.h:12: // Encapsulates everything
required to save a session.
 Maybe add " A session is a set of one or more session windows that share the
same browser state."

https://codereview.chromium.org/2811593004/diff/60001/ios/chrome/browser/sess...
ios/chrome/browser/sessions/session_ios.h:18: // The serialized SessionWindowIOS
objects.
May be empty but never nil?

https://codereview.chromium.org/2811593004/diff/60001/ios/chrome/browser/sess...
File ios/chrome/browser/sessions/session_service_ios_unittest.mm (right):

https://codereview.chromium.org/2811593004/diff/60001/ios/chrome/browser/sess...
ios/chrome/browser/sessions/session_service_ios_unittest.mm:131: // Even if
immediately is YES, the file is created by a task on the task
|immediately|, here and below

https://codereview.chromium.org/2811593004/diff/60001/ios/chrome/browser/tabs...
File ios/chrome/browser/tabs/tab_model.mm (right):

https://codereview.chromium.org/2811593004/diff/60001/ios/chrome/browser/tabs...
ios/chrome/browser/tabs/tab_model.mm:215: @autoreleasepool {
This file isn't ARC yet. Should this be a ScopedAutoreleasePool?

[sdefresne, 2017-04-19 14:35:29]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 14:36:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-04-19 14:54:41]

Please take another look.

https://codereview.chromium.org/2811593004/diff/60001/ios/chrome/browser/sess...
File ios/chrome/browser/sessions/session_ios.h (right):

https://codereview.chromium.org/2811593004/diff/60001/ios/chrome/browser/sess...
ios/chrome/browser/sessions/session_ios.h:12: // Encapsulates everything
required to save a session.
On 2017/04/18 15:16:55, marq wrote:
>  Maybe add " A session is a set of one or more session windows that share the
> same browser state."

Done.

https://codereview.chromium.org/2811593004/diff/60001/ios/chrome/browser/sess...
ios/chrome/browser/sessions/session_ios.h:18: // The serialized SessionWindowIOS
objects.
On 2017/04/18 15:16:55, marq wrote:
> May be empty but never nil?

Done.

https://codereview.chromium.org/2811593004/diff/60001/ios/chrome/browser/sess...
File ios/chrome/browser/sessions/session_service_ios_unittest.mm (right):

https://codereview.chromium.org/2811593004/diff/60001/ios/chrome/browser/sess...
ios/chrome/browser/sessions/session_service_ios_unittest.mm:131: // Even if
immediately is YES, the file is created by a task on the task
On 2017/04/18 15:16:55, marq wrote:
> |immediately|, here and below

Done.

https://codereview.chromium.org/2811593004/diff/60001/ios/chrome/browser/tabs...
File ios/chrome/browser/tabs/tab_model.mm (right):

https://codereview.chromium.org/2811593004/diff/60001/ios/chrome/browser/tabs...
ios/chrome/browser/tabs/tab_model.mm:215: @autoreleasepool {
On 2017/04/18 15:16:55, marq wrote:
> This file isn't ARC yet. Should this be a ScopedAutoreleasePool?

@autoreleasepool is not related to ARC and can be used for file compiled without
ARC. From clang documentation:

  @autoreleasepool may be used in non-ARC translation units,
  with equivalent semantics.

http://clang.llvm.org/docs/AutomaticReferenceCounting.html#autoreleasepool

[marq (ping after 24h), 2017-04-19 15:12:55]

lgtm

[sdefresne, 2017-04-19 15:26:56]

The CQ bit was unchecked by sdefresne@chromium.org

[sdefresne, 2017-04-19 15:26:59]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2017-04-19 15:27:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 15:49:05]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492615619897560,
"parent_rev": "a8835855fb816d7f96b3b009d52b814129a02bde", "commit_rev":
"dcc6c6ec0d3999a98c28a0124ef6ca232ef907a5"}

[commit-bot: I haz the power, 2017-04-19 15:49:12]

Description was changed from

==========
[ios] Allow having multiple session windows in a session.

With the new architecture, there can be multiple WebStateList per
ChromeBrowserState (due to BrowserList owning multiple Browsers).

Introduce SessionIOS that store the information about a session
(e.g. a BrowserList) with a list of SessionWindowIOS objects and
change SessionServiceIOS to use SessionIOS in its API.

Add support for loading legacy saved session with a single root
object of type SessionWindowIOS by creating a SessionIOS on the
fly.

BUG=710848
==========

to

==========
[ios] Allow having multiple session windows in a session.

With the new architecture, there can be multiple WebStateList per
ChromeBrowserState (due to BrowserList owning multiple Browsers).

Introduce SessionIOS that store the information about a session
(e.g. a BrowserList) with a list of SessionWindowIOS objects and
change SessionServiceIOS to use SessionIOS in its API.

Add support for loading legacy saved session with a single root
object of type SessionWindowIOS by creating a SessionIOS on the
fly.

BUG=710848

Review-Url: https://codereview.chromium.org/2811593004
Cr-Commit-Position: refs/heads/master@{#465623}
Committed:
https://chromium.googlesource.com/chromium/src/+/dcc6c6ec0d3999a98c28a0124ef6...
==========

[commit-bot: I haz the power, 2017-04-19 15:49:13]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/dcc6c6ec0d3999a98c28a0124ef6...