ios/chrome/browser/sessions/session_ios.h - Issue 2811593004: [ios] Allow having multiple session windows in a session.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/sessions/session_ios.h

Issue 2811593004: [ios] Allow having multiple session windows in a session. (Closed)

Patch Set: Rebase on origin/master. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_SESSIONS_SESSION_IOS_H_

	6 #define IOS_CHROME_BROWSER_SESSIONS_SESSION_IOS_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 @class SessionWindowIOS;

	11

	12 // Encapsulates everything required to save a session.
	marq (ping after 24h) 2017/04/18 15:16:55 Maybe add " A session is a set of one or more sess Maybe add " A session is a set of one or more session windows that share the same browser state." sdefresne 2017/04/19 14:54:41 Done. Show quoted text On 2017/04/18 15:16:55, marq wrote: > Maybe add " A session is a set of one or more session windows that share the > same browser state." Done.
	13 @interface SessionIOS : NSObject<NSCoding>

	14

	15 - (instancetype)initWithWindows:(NSArray<SessionWindowIOS>)sessionWindows

	16 NS_DESIGNATED_INITIALIZER;

	17

	18 // The serialized SessionWindowIOS objects.
	marq (ping after 24h) 2017/04/18 15:16:55 May be empty but never nil? May be empty but never nil? sdefresne 2017/04/19 14:54:41 Done. Show quoted text On 2017/04/18 15:16:55, marq wrote: > May be empty but never nil? Done.
	19 @property(nonatomic, readonly) NSArray<SessionWindowIOS> sessionWindows;

	20

	21 @end

	22

	23 #endif // IOS_CHROME_BROWSER_SESSIONS_SESSION_IOS_H_

OLD	NEW